<p>Felix Held has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23006">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">superio/ite: pass the chip-specific ops struct to pnp_enable_devices<br><br>Pass the address of the chip-specific ops struct instead of the one of the<br>generic pnp_ops struct to the PNP device enable function.<br><br>Change-Id: I5f03a4064778c419f4b9c50e70db1296addf6c9e<br>Signed-off-by: Felix Held <felix-coreboot@felixheld.de><br>---<br>M src/superio/ite/it8671f/superio.c<br>M src/superio/ite/it8712f/superio.c<br>M src/superio/ite/it8718f/superio.c<br>M src/superio/ite/it8720f/superio.c<br>M src/superio/ite/it8721f/superio.c<br>M src/superio/ite/it8772f/superio.c<br>M src/superio/ite/it8783ef/superio.c<br>7 files changed, 14 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/23006/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/superio/ite/it8671f/superio.c b/src/superio/ite/it8671f/superio.c</span><br><span>index 4fa24de..bc2b571 100644</span><br><span>--- a/src/superio/ite/it8671f/superio.c</span><br><span>+++ b/src/superio/ite/it8671f/superio.c</span><br><span>@@ -58,8 +58,8 @@</span><br><span> </span><br><span> static void enable_dev(struct device *dev)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-        pnp_enable_devices(dev, &pnp_ops,</span><br><span style="color: hsl(0, 100%, 40%);">-           ARRAY_SIZE(pnp_dev_info), pnp_dev_info);</span><br><span style="color: hsl(120, 100%, 40%);">+      pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info),</span><br><span style="color: hsl(120, 100%, 40%);">+           pnp_dev_info);</span><br><span> }</span><br><span> </span><br><span> struct chip_operations superio_ite_it8671f_ops = {</span><br><span>diff --git a/src/superio/ite/it8712f/superio.c b/src/superio/ite/it8712f/superio.c</span><br><span>index 6501a60..ad0ae2b 100644</span><br><span>--- a/src/superio/ite/it8712f/superio.c</span><br><span>+++ b/src/superio/ite/it8712f/superio.c</span><br><span>@@ -77,8 +77,8 @@</span><br><span> </span><br><span> static void enable_dev(struct device *dev)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       pnp_enable_devices(dev, &pnp_ops,</span><br><span style="color: hsl(0, 100%, 40%);">-           ARRAY_SIZE(pnp_dev_info), pnp_dev_info);</span><br><span style="color: hsl(120, 100%, 40%);">+      pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info),</span><br><span style="color: hsl(120, 100%, 40%);">+           pnp_dev_info);</span><br><span> }</span><br><span> </span><br><span> struct chip_operations superio_ite_it8712f_ops = {</span><br><span>diff --git a/src/superio/ite/it8718f/superio.c b/src/superio/ite/it8718f/superio.c</span><br><span>index ca2fedb..c4d361f 100644</span><br><span>--- a/src/superio/ite/it8718f/superio.c</span><br><span>+++ b/src/superio/ite/it8718f/superio.c</span><br><span>@@ -82,8 +82,8 @@</span><br><span> </span><br><span> static void enable_dev(struct device *dev)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       pnp_enable_devices(dev, &pnp_ops,</span><br><span style="color: hsl(0, 100%, 40%);">-           ARRAY_SIZE(pnp_dev_info), pnp_dev_info);</span><br><span style="color: hsl(120, 100%, 40%);">+      pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info),</span><br><span style="color: hsl(120, 100%, 40%);">+           pnp_dev_info);</span><br><span> }</span><br><span> </span><br><span> struct chip_operations superio_ite_it8718f_ops = {</span><br><span>diff --git a/src/superio/ite/it8720f/superio.c b/src/superio/ite/it8720f/superio.c</span><br><span>index 912da38..f13ce33 100644</span><br><span>--- a/src/superio/ite/it8720f/superio.c</span><br><span>+++ b/src/superio/ite/it8720f/superio.c</span><br><span>@@ -91,8 +91,8 @@</span><br><span> </span><br><span> static void enable_dev(struct device *dev)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       pnp_enable_devices(dev, &pnp_ops,</span><br><span style="color: hsl(0, 100%, 40%);">-           ARRAY_SIZE(pnp_dev_info), pnp_dev_info);</span><br><span style="color: hsl(120, 100%, 40%);">+      pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info),</span><br><span style="color: hsl(120, 100%, 40%);">+           pnp_dev_info);</span><br><span> }</span><br><span> </span><br><span> struct chip_operations superio_ite_it8720f_ops = {</span><br><span>diff --git a/src/superio/ite/it8721f/superio.c b/src/superio/ite/it8721f/superio.c</span><br><span>index cd01f30..aa9d398 100644</span><br><span>--- a/src/superio/ite/it8721f/superio.c</span><br><span>+++ b/src/superio/ite/it8721f/superio.c</span><br><span>@@ -63,7 +63,8 @@</span><br><span> </span><br><span> static void enable_dev(struct device *dev)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       pnp_enable_devices(dev, &pnp_ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info);</span><br><span style="color: hsl(120, 100%, 40%);">+        pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info),</span><br><span style="color: hsl(120, 100%, 40%);">+           pnp_dev_info);</span><br><span> }</span><br><span> </span><br><span> struct chip_operations superio_ite_it8721f_ops = {</span><br><span>diff --git a/src/superio/ite/it8772f/superio.c b/src/superio/ite/it8772f/superio.c</span><br><span>index 015db80..e275e29 100644</span><br><span>--- a/src/superio/ite/it8772f/superio.c</span><br><span>+++ b/src/superio/ite/it8772f/superio.c</span><br><span>@@ -288,8 +288,8 @@</span><br><span> </span><br><span> static void enable_dev(struct device *dev)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-     pnp_enable_devices(dev, &pnp_ops,</span><br><span style="color: hsl(0, 100%, 40%);">-           ARRAY_SIZE(pnp_dev_info), pnp_dev_info);</span><br><span style="color: hsl(120, 100%, 40%);">+      pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info),</span><br><span style="color: hsl(120, 100%, 40%);">+           pnp_dev_info);</span><br><span> }</span><br><span> </span><br><span> struct chip_operations superio_ite_it8772f_ops = {</span><br><span>diff --git a/src/superio/ite/it8783ef/superio.c b/src/superio/ite/it8783ef/superio.c</span><br><span>index 71ac4dc..bbd55a0 100644</span><br><span>--- a/src/superio/ite/it8783ef/superio.c</span><br><span>+++ b/src/superio/ite/it8783ef/superio.c</span><br><span>@@ -98,8 +98,8 @@</span><br><span> </span><br><span> static void enable_dev(struct device *dev)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   pnp_enable_devices(dev, &pnp_ops,</span><br><span style="color: hsl(0, 100%, 40%);">-           ARRAY_SIZE(pnp_dev_info), pnp_dev_info);</span><br><span style="color: hsl(120, 100%, 40%);">+      pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info),</span><br><span style="color: hsl(120, 100%, 40%);">+           pnp_dev_info);</span><br><span> }</span><br><span> </span><br><span> struct chip_operations superio_ite_it8783ef_ops = {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23006">change 23006</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23006"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5f03a4064778c419f4b9c50e70db1296addf6c9e </div>
<div style="display:none"> Gerrit-Change-Number: 23006 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de> </div>