<p>Felix Held has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23008">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">superio/nsc: pass the chip-specific ops struct to pnp_enable_devices<br><br>Pass the address of the chip-specific ops struct instead of the one of<br>the generic pnp_ops struct to the PNP device enable function.<br><br>Change-Id: I0c820254e97e3f80470d148552af06940e147b74<br>Signed-off-by: Felix Held <felix-coreboot@felixheld.de><br>---<br>M src/superio/nsc/pc87309/superio.c<br>M src/superio/nsc/pc87366/superio.c<br>M src/superio/nsc/pc87382/superio.c<br>M src/superio/nsc/pc87384/superio.c<br>M src/superio/nsc/pc87392/superio.c<br>M src/superio/nsc/pc87417/superio.c<br>6 files changed, 12 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/23008/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/superio/nsc/pc87309/superio.c b/src/superio/nsc/pc87309/superio.c</span><br><span>index ff36294..c7d3619 100644</span><br><span>--- a/src/superio/nsc/pc87309/superio.c</span><br><span>+++ b/src/superio/nsc/pc87309/superio.c</span><br><span>@@ -54,8 +54,8 @@</span><br><span> </span><br><span> static void enable_dev(struct device *dev)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-      pnp_enable_devices(dev, &pnp_ops,</span><br><span style="color: hsl(0, 100%, 40%);">-           ARRAY_SIZE(pnp_dev_info), pnp_dev_info);</span><br><span style="color: hsl(120, 100%, 40%);">+      pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info),</span><br><span style="color: hsl(120, 100%, 40%);">+           pnp_dev_info);</span><br><span> }</span><br><span> </span><br><span> struct chip_operations superio_nsc_pc87309_ops = {</span><br><span>diff --git a/src/superio/nsc/pc87366/superio.c b/src/superio/nsc/pc87366/superio.c</span><br><span>index 8d5b291..2482ee0 100644</span><br><span>--- a/src/superio/nsc/pc87366/superio.c</span><br><span>+++ b/src/superio/nsc/pc87366/superio.c</span><br><span>@@ -60,8 +60,8 @@</span><br><span> </span><br><span> static void enable_dev(struct device *dev)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       pnp_enable_devices(dev, &pnp_ops,</span><br><span style="color: hsl(0, 100%, 40%);">-           ARRAY_SIZE(pnp_dev_info), pnp_dev_info);</span><br><span style="color: hsl(120, 100%, 40%);">+      pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info),</span><br><span style="color: hsl(120, 100%, 40%);">+           pnp_dev_info);</span><br><span> }</span><br><span> </span><br><span> struct chip_operations superio_nsc_pc87366_ops = {</span><br><span>diff --git a/src/superio/nsc/pc87382/superio.c b/src/superio/nsc/pc87382/superio.c</span><br><span>index 7377c9e..e6b9791 100644</span><br><span>--- a/src/superio/nsc/pc87382/superio.c</span><br><span>+++ b/src/superio/nsc/pc87382/superio.c</span><br><span>@@ -54,8 +54,8 @@</span><br><span> </span><br><span> static void enable_dev(struct device *dev)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       pnp_enable_devices(dev, &pnp_ops,</span><br><span style="color: hsl(0, 100%, 40%);">-           ARRAY_SIZE(pnp_dev_info), pnp_dev_info);</span><br><span style="color: hsl(120, 100%, 40%);">+      pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info),</span><br><span style="color: hsl(120, 100%, 40%);">+           pnp_dev_info);</span><br><span> }</span><br><span> </span><br><span> struct chip_operations superio_nsc_pc87382_ops = {</span><br><span>diff --git a/src/superio/nsc/pc87384/superio.c b/src/superio/nsc/pc87384/superio.c</span><br><span>index bd59a5b..38a931f 100644</span><br><span>--- a/src/superio/nsc/pc87384/superio.c</span><br><span>+++ b/src/superio/nsc/pc87384/superio.c</span><br><span>@@ -39,8 +39,8 @@</span><br><span> </span><br><span> static void enable_dev(struct device *dev)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       pnp_enable_devices(dev, &pnp_ops,</span><br><span style="color: hsl(0, 100%, 40%);">-           ARRAY_SIZE(pnp_dev_info), pnp_dev_info);</span><br><span style="color: hsl(120, 100%, 40%);">+      pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info),</span><br><span style="color: hsl(120, 100%, 40%);">+           pnp_dev_info);</span><br><span> }</span><br><span> </span><br><span> struct chip_operations superio_nsc_pc87384_ops = {</span><br><span>diff --git a/src/superio/nsc/pc87392/superio.c b/src/superio/nsc/pc87392/superio.c</span><br><span>index e75e0a4..a57a5b8 100644</span><br><span>--- a/src/superio/nsc/pc87392/superio.c</span><br><span>+++ b/src/superio/nsc/pc87392/superio.c</span><br><span>@@ -47,8 +47,8 @@</span><br><span> </span><br><span> static void enable_dev(struct device *dev)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       pnp_enable_devices(dev, &pnp_ops,</span><br><span style="color: hsl(0, 100%, 40%);">-           ARRAY_SIZE(pnp_dev_info), pnp_dev_info);</span><br><span style="color: hsl(120, 100%, 40%);">+      pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info),</span><br><span style="color: hsl(120, 100%, 40%);">+           pnp_dev_info);</span><br><span> }</span><br><span> </span><br><span> struct chip_operations superio_nsc_pc87392_ops = {</span><br><span>diff --git a/src/superio/nsc/pc87417/superio.c b/src/superio/nsc/pc87417/superio.c</span><br><span>index 6f9dfe8..7b24d70 100644</span><br><span>--- a/src/superio/nsc/pc87417/superio.c</span><br><span>+++ b/src/superio/nsc/pc87417/superio.c</span><br><span>@@ -60,8 +60,8 @@</span><br><span> </span><br><span> static void enable_dev(struct device *dev)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       pnp_enable_devices(dev, &pnp_ops,</span><br><span style="color: hsl(0, 100%, 40%);">-           ARRAY_SIZE(pnp_dev_info), pnp_dev_info);</span><br><span style="color: hsl(120, 100%, 40%);">+      pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info),</span><br><span style="color: hsl(120, 100%, 40%);">+           pnp_dev_info);</span><br><span> }</span><br><span> </span><br><span> struct chip_operations superio_nsc_pc87417_ops = {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23008">change 23008</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23008"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0c820254e97e3f80470d148552af06940e147b74 </div>
<div style="display:none"> Gerrit-Change-Number: 23008 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de> </div>