<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22997">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/x4x: Disable watchdog, halt TCO timer and clear timeout<br><br>Especially on ICH7 failing to do so results in i2c block read being<br>unusable. On ICH10 this problem doesn't manifest itself that much.<br><br>TESTED on Intel DG41WV: hacking on raminit is much nicer since no<br>need to do a hard power down for +4s are needed to clear the timeouts.<br><br>Change-Id: Icfd3789312704f61000a417f23a121d02d2e7fbe<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/northbridge/intel/x4x/early_init.c<br>M src/southbridge/intel/i82801jx/i82801jx.h<br>2 files changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/22997/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/x4x/early_init.c b/src/northbridge/intel/x4x/early_init.c</span><br><span>index cd11dd9..da79cb7 100644</span><br><span>--- a/src/northbridge/intel/x4x/early_init.c</span><br><span>+++ b/src/northbridge/intel/x4x/early_init.c</span><br><span>@@ -58,6 +58,13 @@</span><br><span>       pci_write_config8(d0f0, D0F0_PAM(5), 0x33);</span><br><span>  pci_write_config8(d0f0, D0F0_PAM(6), 0x33);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+       printk(BIOS_DEBUG, "Disabling Watchdog reboot...");</span><br><span style="color: hsl(120, 100%, 40%);">+ RCBA32(GCS) = RCBA32(GCS) | (1 << 5);     /* No reset */</span><br><span style="color: hsl(120, 100%, 40%);">+        outw((1 << 11), DEFAULT_PMBASE | 0x60 | 0x08);    /* halt timer */</span><br><span style="color: hsl(120, 100%, 40%);">+      outw((1 <<  3), DEFAULT_PMBASE | 0x60 | 0x04);    /* clear timeout */</span><br><span style="color: hsl(120, 100%, 40%);">+   outw((1 <<  1), DEFAULT_PMBASE | 0x60 | 0x06);    /* clear 2nd timeout */</span><br><span style="color: hsl(120, 100%, 40%);">+       printk(BIOS_DEBUG, " done.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  if (!(pci_read_config32(d0f0, D0F0_CAPID0 + 4) & (1 << (46 - 32)))) {</span><br><span>              /* Enable internal GFX */</span><br><span>            pci_write_config32(d0f0, D0F0_DEVEN, BOARD_DEVEN);</span><br><span>diff --git a/src/southbridge/intel/i82801jx/i82801jx.h b/src/southbridge/intel/i82801jx/i82801jx.h</span><br><span>index 9b0f955..88e0ad0 100644</span><br><span>--- a/src/southbridge/intel/i82801jx/i82801jx.h</span><br><span>+++ b/src/southbridge/intel/i82801jx/i82801jx.h</span><br><span>@@ -166,6 +166,7 @@</span><br><span> #define RCBA_RPFN          0x0238</span><br><span> #define RCBA_DMC              0x2010</span><br><span> #define RCBA_HPTC             0x3404</span><br><span style="color: hsl(120, 100%, 40%);">+#define GCS                     0x3410</span><br><span> #define RCBA_BUC              0x3414</span><br><span> #define RCBA_FD                       0x3418 /* Function Disable, see below. */</span><br><span> #define RCBA_CG                    0x341c</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/22997">change 22997</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22997"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Icfd3789312704f61000a417f23a121d02d2e7fbe </div>
<div style="display:none"> Gerrit-Change-Number: 22997 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>