<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22991">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/x4x: Fix computing page_size<br><br>This problem was introduced by 3cf94032b "nb/x4x/raminit: Rewrite SPD<br>decode and timing selection", but was probably not encountered because<br>such dimms are rather uncommon.<br><br>Change-Id: I2d57f5e584ac7fa1479791c239432005fe8c178d<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/northbridge/intel/x4x/raminit.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/22991/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/x4x/raminit.c b/src/northbridge/intel/x4x/raminit.c</span><br><span>index 0b4d4a5..3cd75be 100644</span><br><span>--- a/src/northbridge/intel/x4x/raminit.c</span><br><span>+++ b/src/northbridge/intel/x4x/raminit.c</span><br><span>@@ -188,9 +188,10 @@</span><br><span>      * 1KB page size. For the x16 configuration, the page size is 2KB</span><br><span>     * for all densities except the 256Mb device, which has a 1KB page</span><br><span>    * size." Micron, 'TN-47-16 Designing for High-Density DDR2 Memory'</span><br><span style="color: hsl(120, 100%, 40%);">+       * The formula is pagesize in KiB = width * 2^col_bits / 8.</span><br><span>   */</span><br><span style="color: hsl(0, 100%, 40%);">-     s->dimms[dimm_idx].page_size = s->dimms[dimm_idx].width *</span><br><span style="color: hsl(0, 100%, 40%);">-          (1 << decoded_dimm.col_bits);</span><br><span style="color: hsl(120, 100%, 40%);">+  s->dimms[dimm_idx].page_size = decoded_dimm.width *</span><br><span style="color: hsl(120, 100%, 40%);">+                 (1 << decoded_dimm.col_bits) / 8;</span><br><span> </span><br><span>         switch (decoded_dimm.banks) {</span><br><span>        case 4:</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/22991">change 22991</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22991"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2d57f5e584ac7fa1479791c239432005fe8c178d </div>
<div style="display:none"> Gerrit-Change-Number: 22991 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>