<p><a href="https://review.coreboot.org/22972">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/22972/2/src/mainboard/hp/revolve_810_g1/romstage.c">File src/mainboard/hp/revolve_810_g1/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22972/2/src/mainboard/hp/revolve_810_g1/romstage.c@91">Patch Set #2, Line 91:</a> <code style="font-family:monospace,monospace">    void *spd_file = cbfs_boot_map_with_leak("spd.bin", CBFS_TYPE_SPD,</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">please don't leak the file</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I just follow the common way to read spd files from cbfs, see romstage.c of mb/lenovo/s230u and x1_carbon_gen1</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22972">change 22972</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22972"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iba9c361591697e6a2b3b7b485f7f1649c2a83524 </div>
<div style="display:none"> Gerrit-Change-Number: 22972 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Bill XIE <persmule@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Bill XIE <persmule@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Iru Cai <mytbk920423@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 22 Dec 2017 09:30:04 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>