<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22926">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy: Configure pen reset and eject lines<br><br>This change configures the GPIOs for pen reset and eject lines and<br>exports required properties using ACPI table.<br><br>BUG=b:70773138<br><br>Change-Id: I52f6c3dced54259cde8ee6753275622622e15954<br>Signed-off-by: Furquan Shaikh <furquan@chromium.org><br>---<br>M src/mainboard/google/poppy/variants/baseboard/devicetree.cb<br>M src/mainboard/google/poppy/variants/baseboard/gpio.c<br>2 files changed, 11 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/22926/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb</span><br><span>index 22ef9aa..ceb0c95 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb</span><br><span>@@ -308,6 +308,11 @@</span><br><span> register "generic.hid" = ""WCOM50C1""</span><br><span> register "generic.desc" = ""WCOM Digitizer""</span><br><span> register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D1_IRQ)"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "generic.wake" = "GPE0_DW1_12"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "generic.has_power_resource" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "generic.disable_gpio_export_in_crs" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D3)"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "generic.reset_delay_ms" = "1"</span><br><span> register "hid_desc_reg_offset" = "0x1"</span><br><span> device i2c 0x9 on end</span><br><span> end</span><br><span>diff --git a/src/mainboard/google/poppy/variants/baseboard/gpio.c b/src/mainboard/google/poppy/variants/baseboard/gpio.c</span><br><span>index a0dbbee..d0e2097 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/baseboard/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/baseboard/gpio.c</span><br><span>@@ -166,8 +166,8 @@</span><br><span> PAD_CFG_GPI_APIC(GPP_D1, NONE, PLTRST),</span><br><span> /* D2 : SPI1_MISO ==> PEN_PDCT_L */</span><br><span> PAD_CFG_GPI_GPIO_DRIVER(GPP_D2, NONE, DEEP),</span><br><span style="color: hsl(0, 100%, 40%);">- /* D3 : SPI1_MOSI ==> NC */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NC(GPP_D3),</span><br><span style="color: hsl(120, 100%, 40%);">+ /* D3 : SPI1_MOSI ==> PEN_RST_L */</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_GPO(GPP_D3, 0, DEEP),</span><br><span> /* D4 : FASHTRIG ==> NC */</span><br><span> PAD_CFG_NC(GPP_D4),</span><br><span> /* D5 : ISH_I2C0_SDA ==> ISH_I2C_SENSOR_1V8_SDA */</span><br><span>@@ -176,16 +176,16 @@</span><br><span> PAD_CFG_NF_1V8(GPP_D6, NONE, DEEP, NF1),</span><br><span> /* D7 : ISH_I2C1_SDA ==> NC */</span><br><span> PAD_CFG_NC(GPP_D7),</span><br><span style="color: hsl(0, 100%, 40%);">- /* D8 : ISH_I2C1_SCL ==> NC */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NC(GPP_D8),</span><br><span style="color: hsl(120, 100%, 40%);">+ /* D8 : ISH_I2C1_SCL ==> PEN_EJECT_ODL -- for notification */</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_GPI(GPP_D8, NONE, PLTRST),</span><br><span> /* D9 : ISH_SPI_CS# ==> HP_IRQ_GPIO */</span><br><span> PAD_CFG_GPI_GPIO_DRIVER(GPP_D9, NONE, PLTRST),</span><br><span> /* D10 : ISH_SPI_CLK ==> SPKR_RST_L */</span><br><span> PAD_CFG_GPO(GPP_D10, 1, DEEP),</span><br><span> /* D11 : ISH_SPI_MISO ==> SPKR_INT_L */</span><br><span> PAD_CFG_GPI_APIC(GPP_D11, NONE, PLTRST),</span><br><span style="color: hsl(0, 100%, 40%);">- /* D12 : ISH_SPI_MOSI ==> NC */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NC(GPP_D12),</span><br><span style="color: hsl(120, 100%, 40%);">+ /* D12 : ISH_SPI_MOSI ==> PEN_EJECT_ODL -- for wake event */</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_GPI_ACPI_SCI(GPP_D12, NONE, DEEP, INVERT),</span><br><span> /* D13 : ISH_UART0_RXD ==> NC */</span><br><span> PAD_CFG_NC(GPP_D13),</span><br><span> /* D14 : ISH_UART0_TXD ==> NC */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/22926">change 22926</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22926"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I52f6c3dced54259cde8ee6753275622622e15954 </div>
<div style="display:none"> Gerrit-Change-Number: 22926 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>