<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22934">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd/common/block/pci: Fix validation of pointer<br><br>Procedure write_pci_int_table() does not validates intr_data_ptr. It must<br>be validated together with picr_data_ptr and idx_name.<br><br>BUG=b:69868534<br>TEST=Build fake kahlee with intr_data_ptr not initialized, boot and see<br>error message. Than build correct kahlee and verify that error message<br>is gone.<br><br>Change-Id: I5ee9a362600dbd6325254d7431172501181b52b0<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/soc/amd/common/block/pci/amd_pci_util.c<br>1 file changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/22934/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/common/block/pci/amd_pci_util.c b/src/soc/amd/common/block/pci/amd_pci_util.c</span><br><span>index c5659cb..74bb533 100644</span><br><span>--- a/src/soc/amd/common/block/pci/amd_pci_util.c</span><br><span>+++ b/src/soc/amd/common/block/pci/amd_pci_util.c</span><br><span>@@ -59,11 +59,12 @@</span><br><span>  const struct irq_idx_name *idx_name;</span><br><span> </span><br><span>     idx_name = sb_get_apic_reg_association(&limit);</span><br><span style="color: hsl(0, 100%, 40%);">-     if (picr_data_ptr == NULL || idx_name == NULL) {</span><br><span style="color: hsl(120, 100%, 40%);">+      if (picr_data_ptr == NULL || intr_data_ptr == NULL ||</span><br><span style="color: hsl(120, 100%, 40%);">+     idx_name == NULL) {</span><br><span>              printk(BIOS_ERR, "Warning: Can't write PCI_INTR 0xC00/0xC01"</span><br><span>                           " registers because\n"</span><br><span style="color: hsl(0, 100%, 40%);">-                                "'mainboard_picr_data' or"</span><br><span style="color: hsl(0, 100%, 40%);">-                            " irq_association' tables are NULL\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                         "'mainboard_picr_data' or 'mainboard_intr_data'"</span><br><span style="color: hsl(120, 100%, 40%);">+                            " or 'irq_association'\ntables are NULL\n");</span><br><span>               return;</span><br><span>      }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/22934">change 22934</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22934"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5ee9a362600dbd6325254d7431172501181b52b0 </div>
<div style="display:none"> Gerrit-Change-Number: 22934 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>