<p>Lijian Zhao has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22910">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/common: Fix logic escape in heci code<br><br>If heci get timed out, there's no need to read back reply message to<br>decide the heci recive is successful or not.<br><br>BUG=b:707290799<br>TEST=Boot up method board without battery, and confirm hard reset got<br>trigged after heci time out<br><br>Change-Id: I7c1655284d7027294d8ff5d6a5dbbebe4cbd0c47<br>Signed-off-by: Lijian Zhao <lijian.zhao@intel.com><br>---<br>M src/soc/intel/cannonlake/reset.c<br>M src/soc/intel/common/block/cse/cse.c<br>2 files changed, 5 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/22910/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/cannonlake/reset.c b/src/soc/intel/cannonlake/reset.c<br>index 03f9cb8..60b6bd3 100644<br>--- a/src/soc/intel/cannonlake/reset.c<br>+++ b/src/soc/intel/cannonlake/reset.c<br>@@ -67,14 +67,7 @@<br> <br>        reply_size = sizeof(reply);<br>   memset(&reply, 0, reply_size);<br>-   heci_receive(&reply, &reply_size);<br>-   /* get reply result from HECI MSG  */<br>-        if (reply.result != 0) {<br>-             printk(BIOS_DEBUG, "%s: Exit with Failure\n", __func__);<br>-           return -1;<br>-   }<br>-    printk(BIOS_DEBUG, "%s: Exit with Success\n",  __func__);<br>-  return 0;<br>+    return heci_receive(&reply, &reply_size);<br> }<br> <br> void do_global_reset(void)<br>diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c<br>index 370074e..e3c1d71 100644<br>--- a/src/soc/intel/common/block/cse/cse.c<br>+++ b/src/soc/intel/common/block/cse/cse.c<br>@@ -438,6 +438,10 @@<br>           */<br>           do {<br>                  received = recv_one_message(&hdr, p, left);<br>+                      if (received == 0) {<br>+                         printk(BIOS_ERR, "HECI: Failed t\n");<br>+                              return 1;<br>+                    }<br>                     left -= received;<br>                     p += received;<br>                        /* If we read out everything ping to send more */<br></pre><p>To view, visit <a href="https://review.coreboot.org/22910">change 22910</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22910"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7c1655284d7027294d8ff5d6a5dbbebe4cbd0c47 </div>
<div style="display:none"> Gerrit-Change-Number: 22910 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> </div>