<p>Marshall Dawson has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22902">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd/common: Make AGESA event log parser static<br><br>The function agesawrapper_readeventlog() is not used outside of the<br>wrapper. Relocate it within the file and make it static.<br><br>Change-Id: Ia7fefb4eadbace0cc2fb0f519a1acb7906baaf12<br>Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com><br>---<br>M src/soc/amd/common/block/include/amdblocks/agesawrapper.h<br>M src/soc/amd/common/block/pi/agesawrapper.c<br>2 files changed, 28 insertions(+), 29 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/22902/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/amd/common/block/include/amdblocks/agesawrapper.h b/src/soc/amd/common/block/include/amdblocks/agesawrapper.h<br>index 1b4cde8..d16e9ff 100644<br>--- a/src/soc/amd/common/block/include/amdblocks/agesawrapper.h<br>+++ b/src/soc/amd/common/block/include/amdblocks/agesawrapper.h<br>@@ -40,7 +40,6 @@<br> AGESA_STATUS agesawrapper_amdinitlate(void);<br> AGESA_STATUS agesawrapper_amdinitpost(void);<br> AGESA_STATUS agesawrapper_amdinitmid(void);<br>-AGESA_STATUS agesawrapper_readeventlog(UINT8 HeapStatus);<br> void *agesawrapper_getlateinitptr(int pick);<br> AGESA_STATUS agesawrapper_amdlaterunaptask(UINT32 Func, UINTN Data,<br> void *ConfigPtr);<br>diff --git a/src/soc/amd/common/block/pi/agesawrapper.c b/src/soc/amd/common/block/pi/agesawrapper.c<br>index 5c85430..b9931d2 100644<br>--- a/src/soc/amd/common/block/pi/agesawrapper.c<br>+++ b/src/soc/amd/common/block/pi/agesawrapper.c<br>@@ -40,6 +40,34 @@<br> static void *AcpiCrat;<br> #endif /* #ifndef __PRE_RAM__ */<br> <br>+static AGESA_STATUS agesawrapper_readeventlog(UINT8 HeapStatus)<br>+{<br>+ AGESA_STATUS Status;<br>+ EVENT_PARAMS AmdEventParams = {<br>+ .StdHeader.CalloutPtr = &GetBiosCallout,<br>+ .StdHeader.HeapStatus = HeapStatus,<br>+ };<br>+<br>+ Status = AmdReadEventLog(&AmdEventParams);<br>+ if (AmdEventParams.EventClass)<br>+ printk(BIOS_DEBUG, "AGESA Event Log:\n");<br>+<br>+ while (AmdEventParams.EventClass != 0) {<br>+ printk(BIOS_DEBUG, " Class = %x, Info = %x,"<br>+ " Param1 = 0x%x, Param2 = 0x%x"<br>+ " Param3 = 0x%x, Param4 = 0x%x\n",<br>+ (u32)AmdEventParams.EventClass,<br>+ (u32)AmdEventParams.EventInfo,<br>+ (u32)AmdEventParams.DataParam1,<br>+ (u32)AmdEventParams.DataParam2,<br>+ (u32)AmdEventParams.DataParam3,<br>+ (u32)AmdEventParams.DataParam4);<br>+ Status = AmdReadEventLog(&AmdEventParams);<br>+ }<br>+<br>+ return Status;<br>+}<br>+<br> AGESA_STATUS agesawrapper_amdinitreset(void)<br> {<br> AGESA_STATUS status;<br>@@ -358,34 +386,6 @@<br> if (Status != AGESA_SUCCESS) {<br> /* agesawrapper_readeventlog(); */<br> ASSERT(Status == AGESA_SUCCESS);<br>- }<br>-<br>- return Status;<br>-}<br>-<br>-AGESA_STATUS agesawrapper_readeventlog(UINT8 HeapStatus)<br>-{<br>- AGESA_STATUS Status;<br>- EVENT_PARAMS AmdEventParams = {<br>- .StdHeader.CalloutPtr = &GetBiosCallout,<br>- .StdHeader.HeapStatus = HeapStatus,<br>- };<br>-<br>- Status = AmdReadEventLog(&AmdEventParams);<br>- if (AmdEventParams.EventClass)<br>- printk(BIOS_DEBUG, "AGESA Event Log:\n");<br>-<br>- while (AmdEventParams.EventClass != 0) {<br>- printk(BIOS_DEBUG, " Class = %x, Info = %x,"<br>- " Param1 = 0x%x, Param2 = 0x%x"<br>- " Param3 = 0x%x, Param4 = 0x%x\n",<br>- (u32)AmdEventParams.EventClass,<br>- (u32)AmdEventParams.EventInfo,<br>- (u32)AmdEventParams.DataParam1,<br>- (u32)AmdEventParams.DataParam2,<br>- (u32)AmdEventParams.DataParam3,<br>- (u32)AmdEventParams.DataParam4);<br>- Status = AmdReadEventLog(&AmdEventParams);<br> }<br> <br> return Status;<br></pre><p>To view, visit <a href="https://review.coreboot.org/22902">change 22902</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22902"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia7fefb4eadbace0cc2fb0f519a1acb7906baaf12 </div>
<div style="display:none"> Gerrit-Change-Number: 22902 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>