<p>Vaibhav Shankar has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22875">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/intel/cannonlake_rvp: Disable SATA controller<br><br>SATA was enabled only for internal testing. Since we do not use<br>SATA on chrome platforms, it can be disabled.<br><br>Change-Id: I907b440562b39e6d97f604e7e63b6b99e487aaa8<br>Signed-off-by: Vaibhav Shankar <vaibhav.shankar@intel.com><br>---<br>M src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb<br>M src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb<br>2 files changed, 8 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/22875/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb b/src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb<br>index 2f472e2..a874f4c 100644<br>--- a/src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb<br>+++ b/src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb<br>@@ -30,9 +30,9 @@<br>         register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC0)"<br>       register "usb3_ports[5]" = "USB3_PORT_DEFAULT(OC0)"<br> <br>-   register "SataEnable" = "1"<br>-      register "SataPortsEnable[0]" = "1"<br>-      register "SataPortsEnable[1]" = "1"<br>+      register "SataEnable" = "0"<br>+      register "SataPortsEnable[0]" = "0"<br>+      register "SataPortsEnable[1]" = "0"<br> <br>    register "PchHdaDspEnable" = "1"<br>  register "PchHdaAudioLinkHda" = "1"<br>@@ -95,7 +95,7 @@<br>            device pci 16.3 off end # Management Engine KT Redirection<br>            device pci 16.4 off end # Management Engine Interface 3<br>               device pci 16.5 off end # Management Engine Interface 4<br>-              device pci 17.0 on  end # SATA<br>+               device pci 17.0 off  end # SATA<br>               device pci 19.0 on  end # I2C #4<br>              device pci 19.1 off end # I2C #5<br>              device pci 19.2 on  end # UART #2<br>diff --git a/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb b/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb<br>index ca46d36..0d29a98 100644<br>--- a/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb<br>+++ b/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb<br>@@ -30,9 +30,9 @@<br>     register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC0)"<br>       register "usb3_ports[5]" = "USB3_PORT_DEFAULT(OC0)"<br> <br>-   register "SataEnable" = "1"<br>-      register "SataPortsEnable[0]" = "1"<br>-      register "SataPortsEnable[1]" = "1"<br>+      register "SataEnable" = "0"<br>+      register "SataPortsEnable[0]" = "0"<br>+      register "SataPortsEnable[1]" = "0"<br> <br>    register "PchHdaDspEnable" = "1"<br>  register "PchHdaAudioLinkHda" = "1"<br>@@ -93,7 +93,7 @@<br>            device pci 16.3 off end # Management Engine KT Redirection<br>            device pci 16.4 off end # Management Engine Interface 3<br>               device pci 16.5 off end # Management Engine Interface 4<br>-              device pci 17.0 on  end # SATA<br>+               device pci 17.0 off  end # SATA<br>               device pci 19.0 on  end # I2C #4<br>              device pci 19.1 off end # I2C #5<br>              device pci 19.2 on  end # UART #2<br></pre><p>To view, visit <a href="https://review.coreboot.org/22875">change 22875</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22875"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I907b440562b39e6d97f604e7e63b6b99e487aaa8 </div>
<div style="display:none"> Gerrit-Change-Number: 22875 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vaibhav Shankar <vaibhav.shankar@intel.com> </div>