<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22816">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/x4x/rcven.c: Fix programming coarse offset<br><br>This fixes some bitwise logic errors that caused the coarse offset not<br>to be programmed.<br><br>Change-Id: I41869815f782a2ea1178bdea006e3a7587441323<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/northbridge/intel/x4x/rcven.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/22816/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/northbridge/intel/x4x/rcven.c b/src/northbridge/intel/x4x/rcven.c<br>index 23f8d52..cc45aa9 100644<br>--- a/src/northbridge/intel/x4x/rcven.c<br>+++ b/src/northbridge/intel/x4x/rcven.c<br>@@ -365,8 +365,9 @@<br>                          "medium: %d; tap: %d\n",<br>                            channel, lane, reg8, timing[lane].medium,<br>                             timing[lane].tap);<br>-                   MCHBAR16(0x400 * channel + 0x5fa) &=<br>-                             ~(3 << (lane * 2)) | (reg8 << (lane * 2));<br>+                       MCHBAR16(0x400 * channel + 0x5fa) =<br>+                          (MCHBAR16(0x400 * channel + 0x5fa) &<br>+                             ~(3 << (lane * 2))) | (reg8 << (lane * 2));<br>               }<br>             /* simply use timing[0] to program mincoarse */<br>               timing[0].coarse = mincoarse;<br></pre><p>To view, visit <a href="https://review.coreboot.org/22816">change 22816</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22816"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I41869815f782a2ea1178bdea006e3a7587441323 </div>
<div style="display:none"> Gerrit-Change-Number: 22816 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>