<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22770">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/apollolake: Remove set_subsystem() from SoC<br><br>Intel common PCI driver is handle PCI subsystem ID<br>programming, hence no need to have an explicit soc<br>function to do the same.<br><br>TEST=PCI subsystem id is getting programming during<br>pci enumeration.<br><br>Change-Id: I3eb362ff1f3f6d5c81a0dbe854d8ecd59d5a0453<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/soc/intel/apollolake/chip.c<br>1 file changed, 0 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/22770/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c<br>index 1e78cb1..53ffdb9 100644<br>--- a/src/soc/intel/apollolake/chip.c<br>+++ b/src/soc/intel/apollolake/chip.c<br>@@ -117,20 +117,6 @@<br>      return NULL;<br> }<br> <br>-static void pci_set_subsystem(device_t dev, unsigned vendor, unsigned device)<br>-{<br>-      if (!vendor || !device)<br>-              pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,<br>-                             pci_read_config32(dev, PCI_VENDOR_ID));<br>-      else<br>-         pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,<br>-                             (device << 16) | vendor);<br>-}<br>-<br>-struct pci_operations soc_pci_ops = {<br>-       .set_subsystem = &pci_set_subsystem<br>-};<br>-<br> static void pci_domain_set_resources(device_t dev)<br> {<br>      assign_resources(dev->link_list);<br></pre><p>To view, visit <a href="https://review.coreboot.org/22770">change 22770</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22770"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3eb362ff1f3f6d5c81a0dbe854d8ecd59d5a0453 </div>
<div style="display:none"> Gerrit-Change-Number: 22770 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>