<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22751">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/kahlee: Update GPIOs<br><br>- The touchscreen interrupt was moved from the GPIO 3, as originally<br>suggested to GPIO 11. This changes the gevent from 2 to 18.<br>- Set device enables to high.<br>- Remove Extra SCI comment from GPIO 130.<br>- Set PCIe reset pins to high.<br><br>BUG=b:70234300, b:69681660<br>TEST=build grunt<br><br>Change-Id: Ib591e4278ed23d0963ecb19ad9c326498b4c7796<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/mainboard/google/kahlee/variants/baseboard/gpio.c<br>1 file changed, 17 insertions(+), 17 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/22751/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c<br>index 34b5cee..9308d69 100644<br>--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c<br>+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c<br>@@ -35,11 +35,11 @@<br> /* GPIO_2 - WLAN_PCIE_WAKE_3V3_ODL */<br> { GPIO_2, Function0, FCH_GPIO_PULL_UP_ENABLE },<br> <br>- /* GPIO_3 - TOUCHSCREEN_INT_3V3_ODL, SCI */<br>+ /* GPIO_3 - MEM_VOLT_SEL */<br> { GPIO_3, Function0, FCH_GPIO_PULL_UP_ENABLE },<br> <br> /* GPIO_4 - EN_PP3300_WLAN */<br>- { GPIO_4, Function0, FCH_GPIO_OUTPUT_VALUE },<br>+ { GPIO_4, Function0, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE },<br> <br> /* GPIO_5 - PCH_TRACKPAD_INT_3V3_ODL, SCI */<br> { GPIO_5, Function0, FCH_GPIO_PULL_UP_ENABLE },<br>@@ -59,7 +59,7 @@<br> /* GPIO_10 - SLP_S0_L */<br> { GPIO_10, Function0, FCH_GPIO_PULL_UP_ENABLE },<br> <br>- /* GPIO_11 - Unused (R166) */<br>+ /* GPIO_11 - TOUCHSCREEN_INT_3V3_ODL, SCI */<br> { GPIO_11, Function0, FCH_GPIO_PULL_UP_ENABLE },<br> <br> /* GPIO_12 - Unused (TP126) */<br>@@ -103,7 +103,7 @@<br> { GPIO_25, Function0, FCH_GPIO_PULL_UP_ENABLE },<br> <br> /* GPIO_26 - APU_PCIE_RST_L */<br>- { GPIO_26, Function0, FCH_GPIO_OUTPUT_VALUE },<br>+ { GPIO_26, Function1, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE },<br> <br> /* GPIO_40 - Unused */<br> { GPIO_40, Function0, FCH_GPIO_PULL_UP_ENABLE },<br>@@ -115,7 +115,7 @@<br> { GPIO_67, Function0, FCH_GPIO_OUTPUT_VALUE },<br> <br> /* GPIO_70 - WLAN_PE_RST */<br>- { GPIO_70, Function0, FCH_GPIO_OUTPUT_VALUE },<br>+ { GPIO_70, Function0, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE },<br> <br> /* GPIO_74 - LPC_CLK0_EC_R */<br> { GPIO_74, Function0, FCH_GPIO_PULL_DOWN_ENABLE },<br>@@ -124,7 +124,7 @@<br> { GPIO_75, Function0, FCH_GPIO_PULL_UP_ENABLE },<br> <br> /* GPIO_76 - EN_PP3300_TOUCHSCREEN */<br>- { GPIO_76, Function0, FCH_GPIO_OUTPUT_VALUE },<br>+ { GPIO_76, Function0, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE },<br> <br> /* GPIO_84 - HUB_RST */<br> { GPIO_84, Function1, FCH_GPIO_OUTPUT_VALUE },<br>@@ -142,10 +142,10 @@<br> { GPIO_88, Function0, },<br> <br> /* GPIO_90 - EN_PP3300_CAMERA */<br>- { GPIO_90, Function0, FCH_GPIO_OUTPUT_VALUE },<br>+ { GPIO_90, Function0, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE },<br> <br> /* GPIO_91 - EN_PP3300_TRACKPAD */<br>- { GPIO_91, Function1, FCH_GPIO_OUTPUT_VALUE },<br>+ { GPIO_91, Function1, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE },<br> <br> /* GPIO_92 - WLAN_PCIE_CLKREQ_3V3_ODL */<br> { GPIO_92, Function0, FCH_GPIO_PULL_UP_ENABLE },<br>@@ -198,7 +198,7 @@<br> /* GPIO_129 - APU_KBRST_L */<br> { GPIO_129, Function0, FCH_GPIO_PULL_UP_ENABLE },<br> <br>- /* GPIO_130 - Unused, SCI */<br>+ /* GPIO_130 - Unused */<br> { GPIO_130, Function1, FCH_GPIO_PULL_UP_ENABLE },<br> <br> /* GPIO_131 - CONFIG_STRAP3 */<br>@@ -266,14 +266,6 @@<br> */<br> static const struct sci_source gpe_table[] = {<br> <br>- /* TOUCHSCREEN_INT_3V3_ODL */<br>- {<br>- .scimap = 2,<br>- .gpe = 2,<br>- .direction = SMI_SCI_LVL_HIGH,<br>- .level = SMI_SCI_EDG,<br>- },<br>-<br> /* PCH_TRACKPAD_INT_3V3_ODL */<br> {<br> .scimap = 7,<br>@@ -298,6 +290,14 @@<br> .level = SMI_SCI_LVL,<br> },<br> <br>+ /* TOUCHSCREEN_INT_3V3_ODL */<br>+ {<br>+ .scimap = 18,<br>+ .gpe = 18,<br>+ .direction = SMI_SCI_LVL_HIGH,<br>+ .level = SMI_SCI_EDG,<br>+ },<br>+<br> /* APU_PEN_PDCT_ODL */<br> {<br> .scimap = 21,<br></pre><p>To view, visit <a href="https://review.coreboot.org/22751">change 22751</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22751"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib591e4278ed23d0963ecb19ad9c326498b4c7796 </div>
<div style="display:none"> Gerrit-Change-Number: 22751 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>