<p>Hal Martin has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22736">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/compulab: remove EC replay for Intense-PC<br><br>coreboot console output during POST shows that the EC<br>replay fails to communicate with the EC. Since the replay<br>has no effect, it should be removed from the boot process.<br><br>coreboot log:<br>Replaying EC dump<br>.......Timeout while sending command 0x81 to EC!<br>.......Timeout while sending data 0x00 to EC!<br>(snip)<br>.......Timeout while sending command 0x81 to EC!<br>.......Timeout while sending data 0xff to EC!<br>.......Timeout while sending data 0xff to EC!<br>done<br><br>Change-Id: I05fb6358b40f442337f5768afa6253cd9bc32ee1<br>Signed-off-by: Hal Martin <hal.martin@gmail.com><br>---<br>M src/mainboard/compulab/intense_pc/mainboard.c<br>1 file changed, 0 insertions(+), 43 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/22736/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/compulab/intense_pc/mainboard.c b/src/mainboard/compulab/intense_pc/mainboard.c<br>index f91e44a..f06e900 100644<br>--- a/src/mainboard/compulab/intense_pc/mainboard.c<br>+++ b/src/mainboard/compulab/intense_pc/mainboard.c<br>@@ -22,49 +22,6 @@<br> <br> static void mainboard_init(device_t dev)<br> {<br>- /* FIXME: trim this down or remove if necessary */<br>- {<br>- int i;<br>- const u8 dmp[256] = {<br>- /* 00 */ 0x00, 0x28, 0x00, 0x69, 0x00, 0x00, 0x00, 0x00,<br>- /* 08 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* 10 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* 18 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* 20 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* 28 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x36, 0x3c, 0x6e,<br>- /* 30 */ 0xb8, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* 38 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* 40 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff,<br>- /* 48 */ 0xff, 0x42, 0x54, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* 50 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* 58 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* 60 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* 68 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0xfe, 0xff, 0x41,<br>- /* 70 */ 0x54, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff,<br>- /* 78 */ 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x00, 0x00,<br>- /* 80 */ 0x28, 0x00, 0x00, 0x28, 0x00, 0x00, 0x00, 0x00,<br>- /* 88 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* 90 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* 98 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* a0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* a8 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* b0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* b8 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,<br>- /* c0 */ 0x00, 0x00, 0xc2, 0xc3, 0xc4, 0xc5, 0xc6, 0xc7,<br>- /* c8 */ 0xc8, 0xc9, 0xca, 0xcb, 0xcc, 0xcd, 0xce, 0xcf,<br>- /* d0 */ 0xd0, 0xd1, 0xd2, 0xd3, 0xd4, 0xd5, 0xd6, 0xd7,<br>- /* d8 */ 0xd8, 0xd9, 0xda, 0xdb, 0xdc, 0xdd, 0xde, 0xdf,<br>- /* e0 */ 0xe0, 0xe1, 0xe2, 0xe3, 0xe4, 0xe5, 0xe6, 0xe7,<br>- /* e8 */ 0xe8, 0xe9, 0xea, 0xeb, 0xec, 0xed, 0xee, 0xef,<br>- /* f0 */ 0xf0, 0xf1, 0xf2, 0xf3, 0xf4, 0xf5, 0xf6, 0xf7,<br>- /* f8 */ 0xf8, 0xf9, 0xfa, 0xfb, 0xfc, 0xfd, 0xfe, 0xff,<br>- };<br>-<br>- printk(BIOS_DEBUG, "Replaying EC dump ...");<br>- for (i = 0; i < 256; i++)<br>- ec_write (i, dmp[i]);<br>- printk(BIOS_DEBUG, "done\n");<br>- }<br> pc_keyboard_init(NO_AUX_DEVICE);<br> }<br> <br></pre><p>To view, visit <a href="https://review.coreboot.org/22736">change 22736</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22736"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I05fb6358b40f442337f5768afa6253cd9bc32ee1 </div>
<div style="display:none"> Gerrit-Change-Number: 22736 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Hal Martin <hal.martin+coreboot@gmail.com> </div>