<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22688">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: Fix DSX_CFG macro name for AC_PRESENT<br><br>DSX_CFG provides a config option to disable internal pull-down on<br>AC_PRESENT. This change updates macro name to reflect this correctly.<br><br>Change-Id: I291112858c4ce36667edf30fe303fed437baf5d2<br>Signed-off-by: Furquan Shaikh <furquan@chromium.org><br>---<br>M src/soc/intel/skylake/chip.h<br>M src/soc/intel/skylake/include/soc/pmc.h<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/22688/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h<br>index e539019..4db8382 100644<br>--- a/src/soc/intel/skylake/chip.h<br>+++ b/src/soc/intel/skylake/chip.h<br>@@ -87,7 +87,7 @@<br>     * Deep Sx Configuration<br>       *  DSX_EN_WAKE_PIN       - Enable WAKE# pin<br>   *  DSX_EN_LAN_WAKE_PIN   - Enable LAN_WAKE# pin<br>-      *  DSX_EN_AC_PRESENT_PIN - Enable AC_PRESENT pin<br>+     *  DSX_DIS_AC_PRESENT_PD - Disable pull-down on AC_PRESENT pin<br>        */<br>   uint32_t deep_sx_config;<br> <br>diff --git a/src/soc/intel/skylake/include/soc/pmc.h b/src/soc/intel/skylake/include/soc/pmc.h<br>index bd86f95..36c4a13 100644<br>--- a/src/soc/intel/skylake/include/soc/pmc.h<br>+++ b/src/soc/intel/skylake/include/soc/pmc.h<br>@@ -87,7 +87,7 @@<br> #define DSX_CFG                   0x34<br> #define  DSX_CFG_MASK            0x7<br> #define  DSX_EN_WAKE_PIN  (1 << 2)<br>-#define  DSX_EN_AC_PRESENT_PIN (1 << 1)<br>+#define  DSX_DIS_AC_PRESENT_PD (1 << 1)<br> #define  DSX_EN_LAN_WAKE_PIN   (1 << 0)<br> #define PMSYNC_TPR_CFG         0xc4<br> #define  PMSYNC_LOCK             (1 << 31)<br></pre><p>To view, visit <a href="https://review.coreboot.org/22688">change 22688</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22688"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I291112858c4ce36667edf30fe303fed437baf5d2 </div>
<div style="display:none"> Gerrit-Change-Number: 22688 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>