<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22684">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "soc/intel/skylake: Clean up SoC ASL code."<br><br>This reverts commit a7b97510aeb1652fd0006c9b2d10df6568f37e2e.<br><br>For the internal eMMC to be used by Windows for installation,<br>the CARD device and _RMV methods are required.  Without them,<br>Windows does not see/show the eMMC as a valid installation<br>target.<br><br>TEST: boot google/chell with Tianocore payload and install<br>Windows 10 to the internal eMMC drive.<br><br>Change-Id: I04819ff16ab4cb0d2ea6e1c7f47179f5dacb7cfd<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/soc/intel/skylake/acpi/scs.asl<br>M src/soc/intel/skylake/acpi/systemagent.asl<br>2 files changed, 23 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/22684/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/skylake/acpi/scs.asl b/src/soc/intel/skylake/acpi/scs.asl<br>index 235a57e..e766fd7 100644<br>--- a/src/soc/intel/skylake/acpi/scs.asl<br>+++ b/src/soc/intel/skylake/acpi/scs.asl<br>@@ -101,6 +101,15 @@<br>               Or (PMCR, 0x0003, PMCR)<br>               Store (PMCR, ^TEMP)<br>   }<br>+<br>+ Device (CARD)<br>+        {<br>+            Name (_ADR, 0x00000008)<br>+              Method (_RMV, 0, NotSerialized)<br>+              {<br>+                    Return (0)<br>+           }<br>+    }<br> }<br> <br> #if !IS_ENABLED(CONFIG_EXCLUDE_NATIVE_SD_INTERFACE)<br>@@ -162,5 +171,14 @@<br>          ^^PCRO (PID_GPIOCOM3, 0x4e4, 0x00001000)<br>              ^^PCRO (PID_GPIOCOM3, 0x4f4, 0x00001000)<br>      }<br>+<br>+ Device (CARD)<br>+        {<br>+            Name (_ADR, 0x00000008)<br>+              Method (_RMV, 0, NotSerialized)<br>+              {<br>+                    Return (1)<br>+           }<br>+    }<br> }<br> #endif<br>diff --git a/src/soc/intel/skylake/acpi/systemagent.asl b/src/soc/intel/skylake/acpi/systemagent.asl<br>index a04fe9e..842bb70 100644<br>--- a/src/soc/intel/skylake/acpi/systemagent.asl<br>+++ b/src/soc/intel/skylake/acpi/systemagent.asl<br>@@ -340,6 +340,11 @@<br> <br>              /* HPET address decode range */<br>               Memory32Fixed (ReadWrite, HPET_BASE_ADDRESS, 0x400)<br>+<br>+               /* Debug Base Address<br>+                 * Base Address for ACPI debug output memory buffer<br>+           */<br>+          Memory32Fixed (ReadWrite, 0, 0, DBAD)<br>         })<br> <br>         Method (_CRS, 0, Serialized)<br></pre><p>To view, visit <a href="https://review.coreboot.org/22684">change 22684</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22684"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I04819ff16ab4cb0d2ea6e1c7f47179f5dacb7cfd </div>
<div style="display:none"> Gerrit-Change-Number: 22684 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>