<p>Daisuke Nojiri has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22657">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cr50: Make EC clear AP_OFF before hibnernate<br><br>This patch makes AP send EC_REBOOT_HIBERNATE_CLEAR_AP_OFF, which<br>makes EC clear AP_OFF flag then hibernate.<br><br>This is needed to make Chromebox boot when cr50 toggles the<br>EC's reset line.<br><br>BUG=b:69721737<br>BRANCH=none<br>TEST=Verify Fizz reboot after cr50 update.<br><br>Change-Id: I5f590286393ac21382cab64afdccae92d3fc14ba<br>Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org><br>---<br>M src/ec/google/chromeec/ec_commands.h<br>M src/vendorcode/google/chromeos/cr50_enable_update.c<br>2 files changed, 7 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/22657/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/ec/google/chromeec/ec_commands.h b/src/ec/google/chromeec/ec_commands.h<br>index aa63aa7..ee889b7 100644<br>--- a/src/ec/google/chromeec/ec_commands.h<br>+++ b/src/ec/google/chromeec/ec_commands.h<br>@@ -3785,7 +3785,8 @@<br> /* (command 3 was jump to RW-B) */<br> EC_REBOOT_COLD = 4, /* Cold-reboot */<br> EC_REBOOT_DISABLE_JUMP = 5, /* Disable jump until next reboot */<br>- EC_REBOOT_HIBERNATE = 6 /* Hibernate EC */<br>+ EC_REBOOT_HIBERNATE = 6, /* Hibernate EC */<br>+ EC_REBOOT_HIBERNATE_CLEAR_AP_OFF = 7, /* and clears AP_OFF flag */<br> };<br> <br> /* Flags for ec_params_reboot_ec.reboot_flags */<br>diff --git a/src/vendorcode/google/chromeos/cr50_enable_update.c b/src/vendorcode/google/chromeos/cr50_enable_update.c<br>index 6e67cc2..7917f1c 100644<br>--- a/src/vendorcode/google/chromeos/cr50_enable_update.c<br>+++ b/src/vendorcode/google/chromeos/cr50_enable_update.c<br>@@ -60,10 +60,12 @@<br> printk(BIOS_INFO, "Waiting for CR50 reset to pick up update.\n");<br> <br> if (IS_ENABLED(CONFIG_POWER_OFF_ON_CR50_UPDATE)) {<br>- if (IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC))<br>+ if (IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)) {<br> printk(BIOS_INFO, "Hibernating EC.\n");<br>- google_chromeec_reboot(0, EC_REBOOT_HIBERNATE,<br>- EC_REBOOT_FLAG_ON_AP_SHUTDOWN);<br>+ google_chromeec_reboot(0,<br>+ EC_REBOOT_HIBERNATE_CLEAR_AP_OFF,<br>+ EC_REBOOT_FLAG_ON_AP_SHUTDOWN);<br>+ }<br> poweroff();<br> }<br> halt();<br></pre><p>To view, visit <a href="https://review.coreboot.org/22657">change 22657</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22657"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5f590286393ac21382cab64afdccae92d3fc14ba </div>
<div style="display:none"> Gerrit-Change-Number: 22657 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Daisuke Nojiri <dnojiri@chromium.org> </div>