<p>Furquan Shaikh <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/22615">View Change</a></p><p>Patch set 1:</p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/22615/1/src/soc/intel/skylake/graphics.c">File src/soc/intel/skylake/graphics.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22615/1/src/soc/intel/skylake/graphics.c@17">Patch Set #1, Line 17:</a> <code style="font-family:monospace,monospace">#include <arch/io.h></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is this required?</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22615/1/src/soc/intel/skylake/graphics.c@39">Patch Set #1, Line 39:</a> <code style="font-family:monospace,monospace">graphics_gtt_read</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Before this change, igd_init checked to ensure that the base was not 0 before doing any other operation. The behavior now is not the same.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Do we want to return a success/error for the read/write operations here and bail out early if any of those fail?</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22615/1/src/soc/intel/skylake/graphics.c@86">Patch Set #1, Line 86:</a> <code style="font-family:monospace,monospace">return 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This function always returns 0. Is it really useful to have a return type for the function?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22615">change 22615</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22615"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I416226d0374700cea6eea602f839c3d17f1f39a6 </div>
<div style="display:none"> Gerrit-Change-Number: 22615 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 28 Nov 2017 20:54:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>