<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22625">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">chromeec: Notify CREC device of wakeup events<br><br>Whenever there is a new EC event that could be wake-capable, notify<br>CREC device of this using notification value 0x2 i.e. device<br>wake. This allows Linux kernel to track active_count value correctly<br>for CREC device.<br><br>BUG=b:69118395<br>BRANCH=None<br>TEST=Verified on Soraka:<br>1. Put device into suspend<br>2. Wakeup using mode change/lid open<br>3. Check that the active_count for GOOG0004 has increased<br>(cat wakeup_sources | grep GOOG0004)<br><br>Change-Id: I723f7f4e4c99e7a5b57c6296da66cf30cd413c27<br>Signed-off-by: Furquan Shaikh <furquan@chromium.org><br>---<br>M src/ec/google/chromeec/acpi/ec.asl<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/22625/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl<br>index 0d05110..d295a8d 100644<br>--- a/src/ec/google/chromeec/acpi/ec.asl<br>+++ b/src/ec/google/chromeec/acpi/ec.asl<br>@@ -212,6 +212,7 @@<br> {<br> Store ("EC: LID OPEN", Debug)<br> Store (LIDS, \LIDS)<br>+ Notify (CREC, 0x2)<br> #ifdef EC_ENABLE_LID_SWITCH<br> Notify (LID0, 0x80)<br> #endif<br>@@ -297,6 +298,7 @@<br> Method (_Q0D, 0, NotSerialized)<br> {<br> Store ("EC: KEY PRESSED", Debug)<br>+ Notify (CREC, 0x2)<br> }<br> <br> // Thermal Shutdown Imminent<br>@@ -354,17 +356,18 @@<br> Notify (CREC, 0x80)<br> }<br> <br>-#ifdef EC_ENABLE_TABLET_EVENT<br> // TABLET mode switch Event<br> Method (_Q1D, 0, NotSerialized)<br> {<br> Store ("EC: TABLET mode switch Event", Debug)<br>+ Notify (CREC, 0x2)<br>+#ifdef EC_ENABLE_TABLET_EVENT<br> If (CondRefOf (\_SB.DPTF.TPET)) {<br> \_SB.DPTF.TPET()<br> }<br> Notify (TBMC, 0x80)<br>- }<br> #endif<br>+ }<br> <br> /*<br> * Dynamic Platform Thermal Framework support<br></pre><p>To view, visit <a href="https://review.coreboot.org/22625">change 22625</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22625"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I723f7f4e4c99e7a5b57c6296da66cf30cd413c27 </div>
<div style="display:none"> Gerrit-Change-Number: 22625 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>