<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22612">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check<br><br>Coverity reported pointer dev being dereferenced when assigning pointer<br>conf, before checking dev for NULL. Pointer dev must be NULL checked<br>before assigning a value to pointer conf.<br><br>BUG=b:69669995<br><br>Change-Id: Ic435b1290c9d3667b890ecc29c5147a25c16b96f<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/soc/amd/stoneyridge/dimm_spd.c<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/22612/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/amd/stoneyridge/dimm_spd.c b/src/soc/amd/stoneyridge/dimm_spd.c<br>index d9f6355..26cd335 100644<br>--- a/src/soc/amd/stoneyridge/dimm_spd.c<br>+++ b/src/soc/amd/stoneyridge/dimm_spd.c<br>@@ -26,9 +26,12 @@<br> {<br>       uint8_t spd_address;<br>  DEVTREE_CONST struct device *dev = dev_find_slot(0, DCT_DEVFN);<br>-      DEVTREE_CONST struct soc_amd_stoneyridge_config *conf = dev->chip_info;<br>+   DEVTREE_CONST struct soc_amd_stoneyridge_config *conf;<br> <br>-    if ((dev == 0) || (conf == 0))<br>+       if (dev == 0)<br>+                return AGESA_ERROR;<br>+  conf = dev->chip_info;<br>+    if (conf == 0)<br>                return AGESA_ERROR;<br>   if (info->SocketId >= ARRAY_SIZE(conf->spd_addr_lookup))<br>             return AGESA_ERROR;<br></pre><p>To view, visit <a href="https://review.coreboot.org/22612">change 22612</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22612"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic435b1290c9d3667b890ecc29c5147a25c16b96f </div>
<div style="display:none"> Gerrit-Change-Number: 22612 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>