<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22599">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/intelmetool: Add Skylake support<br><br>Skylake doesn't have RCBA anymore.<br><br>Don't try to access RCBA on Skylake platforms.<br><br>FIXME: Add support for P2SB.<br><br>Change-Id: I920b1dac124bf0fc6d13fd9ceab12ecd575c1252<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>---<br>M util/intelmetool/intelmetool.c<br>1 file changed, 26 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/22599/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/util/intelmetool/intelmetool.c b/util/intelmetool/intelmetool.c<br>index 0b0e509..65249bd 100644<br>--- a/util/intelmetool/intelmetool.c<br>+++ b/util/intelmetool/intelmetool.c<br>@@ -75,6 +75,22 @@<br>   return !strncmp((char *)&regs, "GenuineIntel", CPU_ID_SIZE-1);<br> }<br> <br>+static int isSkylakeCompatibel(void)<br>+{<br>+       regs_t regs;<br>+ unsigned int level = 0;<br>+      unsigned int family, model, ext_model;<br>+       unsigned int eax = 1;<br>+<br>+     __get_cpuid(level, &eax, &regs.ebx, &regs.ecx, &regs.edx);<br>+<br>+        family = ((eax & 0xf00) >> 8);<br>+     ext_model = ((eax & 0xf0000) >> 12);<br>+       model = ((eax & 0xf0) >> 4);<br>+       return (family == 6 && model == 0xe && ext_model == 4) &&<br>+            (family == 6 && model == 0xe && ext_model == 5);<br>+}<br>+<br> /* You need >4GB total ram, in kernel cmdline, use 'mem=1000m'<br>  * then this code will clone to absolute memory address 0xe0000000<br>  * which can be read using a mmap tool at that offset.<br>@@ -178,6 +194,11 @@<br> <br> static int activate_me(void)<br> {<br>+        /* RCBA is supported up to Intel's 5th Gen. CPUs */<br>+      if (isSkylakeCompatibel())<br>+           /* FIXME: Add Skylake support */<br>+             return 0;<br>+<br>  if (read_rcba32(FD2, &fd2)) {<br>             printf("Error reading RCBA\n");<br>             return 1;<br>@@ -197,6 +218,11 @@<br> <br> static void rehide_me(void)<br> {<br>+ /* RCBA is supported up to Intel's 5th Gen. CPUs */<br>+      if (isSkylakeCompatibel())<br>+           /* FIXME: Add Skylake support */<br>+             return;<br>+<br>    if (fd2 & 0x2) {<br>          if (debug)<br>                    printf("Re-hiding MEI device...");<br></pre><p>To view, visit <a href="https://review.coreboot.org/22599">change 22599</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22599"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I920b1dac124bf0fc6d13fd9ceab12ecd575c1252 </div>
<div style="display:none"> Gerrit-Change-Number: 22599 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>