<p>Chris Wang would like Chris Wang to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/22589">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nautilus: set I2C speed to 400KHz<br><br>Add "speed_config" for each I2C port configuration to set speed to<br>400KHz.<br><br>BRANCH=master<br>BUG=none<br>TEST=compiled/verified<br><br>Change-Id: Icb48733b87cefc92577547b1eab661a8cbb12be6<br>Signed-off-by: Chris Wang <chriswang@ami.corp-partner.google.com><br>---<br>M src/mainboard/google/poppy/variants/nautilus/devicetree.cb<br>1 file changed, 53 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/22589/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb<br>index 6ee7a52..83feda5 100644<br>--- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb<br>+++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb<br>@@ -78,6 +78,7 @@<br> register "SlowSlewRateForIa" = "3" # Fast/16<br> register "SlowSlewRateForGt" = "3" # Fast/16<br> register "SlowSlewRateForSa" = "3" # Fast/16<br>+<br> # VR Settings Configuration for 4 Domains<br> #+----------------+-------+-------+-------+-------+<br> #| Domain/Setting | SA | IA | GTUS | GTS |<br>@@ -175,6 +176,15 @@<br> <br> # Touchscreen<br> register "i2c_voltage[0]" = "I2C_VOLTAGE_3V3"<br>+ register "i2c[0]" = "{<br>+ .speed = I2C_SPEED_FAST,<br>+ .speed_config[0] = {<br>+ .speed = I2C_SPEED_FAST,<br>+ .scl_lcnt = 190,<br>+ .scl_hcnt = 100,<br>+ .sda_hold = 36,<br>+ },<br>+ }"<br> <br> # H1<br> register "i2c_voltage[1]" = "I2C_VOLTAGE_3V3"<br>@@ -182,20 +192,62 @@<br> # for TPM communication before memory is up.<br> register "i2c[1]" = "{<br> .early_init = 1,<br>+ .speed = I2C_SPEED_FAST,<br>+ .speed_config[0] = {<br>+ .speed = I2C_SPEED_FAST,<br>+ .scl_lcnt = 190,<br>+ .scl_hcnt = 100,<br>+ .sda_hold = 36,<br>+ },<br> }"<br> <br> # Trackpad<br> register "i2c_voltage[2]" = "I2C_VOLTAGE_1V8"<br>+ register "i2c[2]" = "{<br>+ .speed = I2C_SPEED_FAST,<br>+ .speed_config[0] = {<br>+ .speed = I2C_SPEED_FAST,<br>+ .scl_lcnt = 190,<br>+ .scl_hcnt = 100,<br>+ .sda_hold = 36,<br>+ },<br>+ }"<br> <br> # Pen<br> register "i2c_voltage[3]" = "I2C_VOLTAGE_1V8"<br>+ register "i2c[3]" = "{<br>+ .speed = I2C_SPEED_FAST,<br>+ .speed_config[0] = {<br>+ .speed = I2C_SPEED_FAST,<br>+ .scl_lcnt = 190,<br>+ .scl_hcnt = 100,<br>+ .sda_hold = 36,<br>+ },<br>+ }"<br> <br> # Camera<br> register "i2c_voltage[4]" = "I2C_VOLTAGE_1V8"<br>+ register "i2c[4]" = "{<br>+ .speed = I2C_SPEED_FAST,<br>+ .speed_config[0] = {<br>+ .speed = I2C_SPEED_FAST,<br>+ .scl_lcnt = 190,<br>+ .scl_hcnt = 100,<br>+ .sda_hold = 36,<br>+ },<br>+ }"<br> <br> # Audio<br> register "i2c_voltage[5]" = "I2C_VOLTAGE_1V8"<br>-<br>+ register "i2c[5]" = "{<br>+ .speed = I2C_SPEED_FAST,<br>+ .speed_config[0] = {<br>+ .speed = I2C_SPEED_FAST,<br>+ .scl_lcnt = 190,<br>+ .scl_hcnt = 100,<br>+ .sda_hold = 36,<br>+ },<br>+ }"<br> <br> # Must leave UART0 enabled or SD/eMMC will not work as PCI<br> register "SerialIoDevMode" = "{<br>@@ -210,13 +262,6 @@<br> [PchSerialIoIndexUart0] = PchSerialIoPci,<br> [PchSerialIoIndexUart1] = PchSerialIoDisabled,<br> [PchSerialIoIndexUart2] = PchSerialIoSkipInit,<br>- }"<br>-<br>- # Enable I2C5 for audio codec at 400kHz<br>- register "i2c[5]" = "{<br>- .speed = I2C_SPEED_FAST,<br>- .rise_time_ns = 104,<br>- .fall_time_ns = 52,<br> }"<br> <br> register "speed_shift_enable" = "1"<br></pre><p>To view, visit <a href="https://review.coreboot.org/22589">change 22589</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22589"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Icb48733b87cefc92577547b1eab661a8cbb12be6 </div>
<div style="display:none"> Gerrit-Change-Number: 22589 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Chris Wang <chriswang@ami.com.tw> </div>
<div style="display:none"> Gerrit-Reviewer: Chris Wang <chriswang@ami.corp-partner.google.com> </div>