<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22591">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">kahlee/ec.c: Use new wide IO function<br><br>In preparation to deleting early_setup,c, change early_ec_init() to use new<br>southbridge.c function sb_set_wideio_range and remove <#ifdef __PRE_RAM__>.<br><br>BUG=b:64033893<br><br>Change-Id: Iaea17f4f636aab6bd8b05b1b3bed53a677164e74<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/mainboard/google/kahlee/ec.c<br>1 file changed, 6 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/22591/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/kahlee/ec.c b/src/mainboard/google/kahlee/ec.c<br>index 3f309eb..bbe989d 100644<br>--- a/src/mainboard/google/kahlee/ec.c<br>+++ b/src/mainboard/google/kahlee/ec.c<br>@@ -36,9 +36,9 @@<br> <br> static void early_ec_init(void)<br> {<br>-#ifdef __PRE_RAM__<br>  uint16_t ec_ioport_base;<br>      size_t ec_ioport_size;<br>+       uint8_t status;<br> <br>    /*<br>     * Set up LPC decoding for the ChromeEC I/O port ranges:<br>@@ -50,8 +50,11 @@<br>  printk(BIOS_DEBUG,<br>            "LPC Setup google_chromeec_ioport_range: %04x, %08zx\n",<br>            ec_ioport_base, ec_ioport_size);<br>-     lpc_wideio_512_window(ec_ioport_base);<br>-#endif //_PRE_RAM_<br>+  status = sb_set_wideio_range(ec_ioport_base, ec_ioport_size);<br>+        if (status == WIDE_IO_RANGE_FAILED)<br>+          printk(BIOS_WARNING, "ERROR: Failed to assign a range\n");<br>+ else<br>+         printk(BIOS_DEBUG, "Range assigned to wide IO %d\n", status);<br> }<br> <br> void mainboard_ec_init(void)<br></pre><p>To view, visit <a href="https://review.coreboot.org/22591">change 22591</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22591"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iaea17f4f636aab6bd8b05b1b3bed53a677164e74 </div>
<div style="display:none"> Gerrit-Change-Number: 22591 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>