<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22578">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">AMD platforms: Fix ASL comment that implies "\_SB" is southbridge<br><br>Change-Id: I6ee86396a1c5aaee248a275b42da801cedace586<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/mainboard/advansus/a785e-i/dsdt.asl<br>M src/mainboard/amd/bimini_fam10/dsdt.asl<br>M src/mainboard/amd/dbm690t/dsdt.asl<br>M src/mainboard/amd/dinar/dsdt.asl<br>M src/mainboard/amd/mahogany/dsdt.asl<br>M src/mainboard/amd/mahogany_fam10/dsdt.asl<br>M src/mainboard/amd/pistachio/dsdt.asl<br>M src/mainboard/amd/tilapia_fam10/dsdt.asl<br>M src/mainboard/amd/torpedo/dsdt.asl<br>M src/mainboard/asrock/939a785gmh/dsdt.asl<br>M src/mainboard/asus/m4a78-em/dsdt.asl<br>M src/mainboard/asus/m4a785-m/dsdt.asl<br>M src/mainboard/asus/m4a785t-m/dsdt.asl<br>M src/mainboard/asus/m5a88-v/dsdt.asl<br>M src/mainboard/avalue/eax-785e/dsdt.asl<br>M src/mainboard/gigabyte/ma785gm/dsdt.asl<br>M src/mainboard/gigabyte/ma785gmt/dsdt.asl<br>M src/mainboard/gigabyte/ma78gm/dsdt.asl<br>M src/mainboard/iei/kino-780am2-fam10/dsdt.asl<br>M src/mainboard/jetway/pa78vm5/dsdt.asl<br>M src/mainboard/kontron/kt690/dsdt.asl<br>M src/mainboard/lippert/frontrunner-af/dsdt.asl<br>M src/mainboard/lippert/toucan-af/dsdt.asl<br>M src/mainboard/siemens/sitemp_g1p1/dsdt.asl<br>M src/mainboard/technexion/tim5690/dsdt.asl<br>M src/mainboard/technexion/tim8690/dsdt.asl<br>M src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl<br>M src/southbridge/amd/agesa/hudson/acpi/fch.asl<br>M src/southbridge/amd/cimx/sb800/acpi/fch.asl<br>M src/southbridge/amd/pi/hudson/acpi/fch.asl<br>30 files changed, 30 insertions(+), 30 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/22578/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/advansus/a785e-i/dsdt.asl b/src/mainboard/advansus/a785e-i/dsdt.asl<br>index 6446ef2..7952642 100644<br>--- a/src/mainboard/advansus/a785e-i/dsdt.asl<br>+++ b/src/mainboard/advansus/a785e-i/dsdt.asl<br>@@ -1129,7 +1129,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/amd/bimini_fam10/dsdt.asl b/src/mainboard/amd/bimini_fam10/dsdt.asl<br>index 7dbec9a..c6b0ad2 100644<br>--- a/src/mainboard/amd/bimini_fam10/dsdt.asl<br>+++ b/src/mainboard/amd/bimini_fam10/dsdt.asl<br>@@ -1129,7 +1129,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/amd/dbm690t/dsdt.asl b/src/mainboard/amd/dbm690t/dsdt.asl<br>index 52eedf1..78ceb01 100644<br>--- a/src/mainboard/amd/dbm690t/dsdt.asl<br>+++ b/src/mainboard/amd/dbm690t/dsdt.asl<br>@@ -1097,7 +1097,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/amd/dinar/dsdt.asl b/src/mainboard/amd/dinar/dsdt.asl<br>index 773e5ba..08bbe80 100644<br>--- a/src/mainboard/amd/dinar/dsdt.asl<br>+++ b/src/mainboard/amd/dinar/dsdt.asl<br>@@ -797,7 +797,7 @@<br> Scope(\_GPE) { /* Start Scope GPE */<br> } /* End Scope GPE */<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include "../../../arch/x86/acpi/globutil.asl" /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/amd/mahogany/dsdt.asl b/src/mainboard/amd/mahogany/dsdt.asl<br>index dba4751..798f053 100644<br>--- a/src/mainboard/amd/mahogany/dsdt.asl<br>+++ b/src/mainboard/amd/mahogany/dsdt.asl<br>@@ -1093,7 +1093,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/amd/mahogany_fam10/dsdt.asl b/src/mainboard/amd/mahogany_fam10/dsdt.asl<br>index 3790fc9..bbc3105 100644<br>--- a/src/mainboard/amd/mahogany_fam10/dsdt.asl<br>+++ b/src/mainboard/amd/mahogany_fam10/dsdt.asl<br>@@ -1135,7 +1135,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/amd/pistachio/dsdt.asl b/src/mainboard/amd/pistachio/dsdt.asl<br>index 437dbbf..79589a8 100644<br>--- a/src/mainboard/amd/pistachio/dsdt.asl<br>+++ b/src/mainboard/amd/pistachio/dsdt.asl<br>@@ -1096,7 +1096,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/amd/tilapia_fam10/dsdt.asl b/src/mainboard/amd/tilapia_fam10/dsdt.asl<br>index 455293c..03118ee 100644<br>--- a/src/mainboard/amd/tilapia_fam10/dsdt.asl<br>+++ b/src/mainboard/amd/tilapia_fam10/dsdt.asl<br>@@ -1135,7 +1135,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/amd/torpedo/dsdt.asl b/src/mainboard/amd/torpedo/dsdt.asl<br>index 6947cc2..5781754 100644<br>--- a/src/mainboard/amd/torpedo/dsdt.asl<br>+++ b/src/mainboard/amd/torpedo/dsdt.asl<br>@@ -768,7 +768,7 @@<br> Scope(\_GPE) { /* Start Scope GPE */<br> } /* End Scope GPE */<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/asrock/939a785gmh/dsdt.asl b/src/mainboard/asrock/939a785gmh/dsdt.asl<br>index 4622fe2..9c50f96 100644<br>--- a/src/mainboard/asrock/939a785gmh/dsdt.asl<br>+++ b/src/mainboard/asrock/939a785gmh/dsdt.asl<br>@@ -432,7 +432,7 @@<br> <br> Name(WKST,Package(){Zero, Zero})<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/asus/m4a78-em/dsdt.asl b/src/mainboard/asus/m4a78-em/dsdt.asl<br>index 1f91baf..f681814 100644<br>--- a/src/mainboard/asus/m4a78-em/dsdt.asl<br>+++ b/src/mainboard/asus/m4a78-em/dsdt.asl<br>@@ -1135,7 +1135,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/asus/m4a785-m/dsdt.asl b/src/mainboard/asus/m4a785-m/dsdt.asl<br>index 1f91baf..f681814 100644<br>--- a/src/mainboard/asus/m4a785-m/dsdt.asl<br>+++ b/src/mainboard/asus/m4a785-m/dsdt.asl<br>@@ -1135,7 +1135,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/asus/m4a785t-m/dsdt.asl b/src/mainboard/asus/m4a785t-m/dsdt.asl<br>index 189e0d6..ef9c027 100644<br>--- a/src/mainboard/asus/m4a785t-m/dsdt.asl<br>+++ b/src/mainboard/asus/m4a785t-m/dsdt.asl<br>@@ -1135,7 +1135,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/asus/m5a88-v/dsdt.asl b/src/mainboard/asus/m5a88-v/dsdt.asl<br>index ac9676f..0b83173 100644<br>--- a/src/mainboard/asus/m5a88-v/dsdt.asl<br>+++ b/src/mainboard/asus/m5a88-v/dsdt.asl<br>@@ -1129,7 +1129,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/avalue/eax-785e/dsdt.asl b/src/mainboard/avalue/eax-785e/dsdt.asl<br>index 510e912..c0a10ac 100644<br>--- a/src/mainboard/avalue/eax-785e/dsdt.asl<br>+++ b/src/mainboard/avalue/eax-785e/dsdt.asl<br>@@ -1129,7 +1129,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/gigabyte/ma785gm/dsdt.asl b/src/mainboard/gigabyte/ma785gm/dsdt.asl<br>index 09f8a92..030ddb9 100644<br>--- a/src/mainboard/gigabyte/ma785gm/dsdt.asl<br>+++ b/src/mainboard/gigabyte/ma785gm/dsdt.asl<br>@@ -1135,7 +1135,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/gigabyte/ma785gmt/dsdt.asl b/src/mainboard/gigabyte/ma785gmt/dsdt.asl<br>index 09f8a92..030ddb9 100644<br>--- a/src/mainboard/gigabyte/ma785gmt/dsdt.asl<br>+++ b/src/mainboard/gigabyte/ma785gmt/dsdt.asl<br>@@ -1135,7 +1135,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/gigabyte/ma78gm/dsdt.asl b/src/mainboard/gigabyte/ma78gm/dsdt.asl<br>index 09f8a92..030ddb9 100644<br>--- a/src/mainboard/gigabyte/ma78gm/dsdt.asl<br>+++ b/src/mainboard/gigabyte/ma78gm/dsdt.asl<br>@@ -1135,7 +1135,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/iei/kino-780am2-fam10/dsdt.asl b/src/mainboard/iei/kino-780am2-fam10/dsdt.asl<br>index d99c55d..9935d94 100644<br>--- a/src/mainboard/iei/kino-780am2-fam10/dsdt.asl<br>+++ b/src/mainboard/iei/kino-780am2-fam10/dsdt.asl<br>@@ -1135,7 +1135,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/jetway/pa78vm5/dsdt.asl b/src/mainboard/jetway/pa78vm5/dsdt.asl<br>index 3112d92..bbd4381 100644<br>--- a/src/mainboard/jetway/pa78vm5/dsdt.asl<br>+++ b/src/mainboard/jetway/pa78vm5/dsdt.asl<br>@@ -1135,7 +1135,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/kontron/kt690/dsdt.asl b/src/mainboard/kontron/kt690/dsdt.asl<br>index 250671a..982f105 100644<br>--- a/src/mainboard/kontron/kt690/dsdt.asl<br>+++ b/src/mainboard/kontron/kt690/dsdt.asl<br>@@ -1098,7 +1098,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/lippert/frontrunner-af/dsdt.asl b/src/mainboard/lippert/frontrunner-af/dsdt.asl<br>index 583421d..f189106 100644<br>--- a/src/mainboard/lippert/frontrunner-af/dsdt.asl<br>+++ b/src/mainboard/lippert/frontrunner-af/dsdt.asl<br>@@ -1125,7 +1125,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/lippert/toucan-af/dsdt.asl b/src/mainboard/lippert/toucan-af/dsdt.asl<br>index 898f9cc..f74a44d 100644<br>--- a/src/mainboard/lippert/toucan-af/dsdt.asl<br>+++ b/src/mainboard/lippert/toucan-af/dsdt.asl<br>@@ -1124,7 +1124,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/siemens/sitemp_g1p1/dsdt.asl b/src/mainboard/siemens/sitemp_g1p1/dsdt.asl<br>index 6cf137f..3418af2 100644<br>--- a/src/mainboard/siemens/sitemp_g1p1/dsdt.asl<br>+++ b/src/mainboard/siemens/sitemp_g1p1/dsdt.asl<br>@@ -363,7 +363,7 @@<br> #include "acpi/routing.asl"<br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB)<br> {<br> /* Start \_SB scope */<br>diff --git a/src/mainboard/technexion/tim5690/dsdt.asl b/src/mainboard/technexion/tim5690/dsdt.asl<br>index 8fc0fdb..f2e11ea 100644<br>--- a/src/mainboard/technexion/tim5690/dsdt.asl<br>+++ b/src/mainboard/technexion/tim5690/dsdt.asl<br>@@ -1097,7 +1097,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/mainboard/technexion/tim8690/dsdt.asl b/src/mainboard/technexion/tim8690/dsdt.asl<br>index 2882869..177a16d 100644<br>--- a/src/mainboard/technexion/tim8690/dsdt.asl<br>+++ b/src/mainboard/technexion/tim8690/dsdt.asl<br>@@ -1097,7 +1097,7 @@<br> <br> #include "acpi/usb.asl"<br> <br>- /* South Bridge */<br>+ /* System Bus */<br> Scope(\_SB) { /* Start \_SB scope */<br> #include <arch/x86/acpi/globutil.asl> /* global utility methods expected within the \_SB scope */<br> <br>diff --git a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl<br>index 6dcafe6..216b57c 100644<br>--- a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl<br>+++ b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl<br>@@ -14,7 +14,7 @@<br> * GNU General Public License for more details.<br> */<br> <br>-/* South Bridge */<br>+/* System Bus */<br> /* _SB.PCI0 */<br> <br> /* Operating System Capabilities Method */<br>diff --git a/src/southbridge/amd/agesa/hudson/acpi/fch.asl b/src/southbridge/amd/agesa/hudson/acpi/fch.asl<br>index 6c8e5fc..efd6a93 100644<br>--- a/src/southbridge/amd/agesa/hudson/acpi/fch.asl<br>+++ b/src/southbridge/amd/agesa/hudson/acpi/fch.asl<br>@@ -14,7 +14,7 @@<br> * GNU General Public License for more details.<br> */<br> <br>-/* South Bridge */<br>+/* System Bus */<br> /* _SB.PCI0 */<br> <br> /* Operating System Capabilities Method */<br>diff --git a/src/southbridge/amd/cimx/sb800/acpi/fch.asl b/src/southbridge/amd/cimx/sb800/acpi/fch.asl<br>index 5abfcfe..816988b 100644<br>--- a/src/southbridge/amd/cimx/sb800/acpi/fch.asl<br>+++ b/src/southbridge/amd/cimx/sb800/acpi/fch.asl<br>@@ -13,7 +13,7 @@<br> * GNU General Public License for more details.<br> */<br> <br>-/* South Bridge */<br>+/* System Bus */<br> /* _SB.PCI0 */<br> <br> /* Operating System Capabilities Method */<br>diff --git a/src/southbridge/amd/pi/hudson/acpi/fch.asl b/src/southbridge/amd/pi/hudson/acpi/fch.asl<br>index 5f00436..2586dd4 100644<br>--- a/src/southbridge/amd/pi/hudson/acpi/fch.asl<br>+++ b/src/southbridge/amd/pi/hudson/acpi/fch.asl<br>@@ -14,7 +14,7 @@<br> * GNU General Public License for more details.<br> */<br> <br>-/* South Bridge */<br>+/* System Bus */<br> /* _SB.PCI0 */<br> <br> /* Operating System Capabilities Method */<br></pre><p>To view, visit <a href="https://review.coreboot.org/22578">change 22578</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22578"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6ee86396a1c5aaee248a275b42da801cedace586 </div>
<div style="display:none"> Gerrit-Change-Number: 22578 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>