<p>Pratikkumar V Prajapati <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/22549">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/22549/1/src/soc/intel/cannonlake/reset.c">File src/soc/intel/cannonlake/reset.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22549/1/src/soc/intel/cannonlake/reset.c@83">Patch Set #1, Line 83:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">if(!send_heci_reset_message())<br>         return;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">We dont want to return from here if heci reset fails. we would try pmc and then hard_reset in sequence.</p><p style="white-space: pre-wrap; word-wrap: break-word;">This change is not needed.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22549">change 22549</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22549"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I5bb12554e5745d7704a1b684a3a51034bb35f787 </div>
<div style="display:none"> Gerrit-Change-Number: 22549 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: John Zhao <john.zhao@intel.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: John Zhao <john.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati@intel.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 21 Nov 2017 04:26:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>