<p>Lin Huang has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22529">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/gru: correct backlight gpio<br><br>it use backlight enable pin as backlight gpio before, correct it and<br>define the right backlight gpio.<br><br>Change-Id: I7c5abfd5bbbae015b899f3edc8892ea32bf82463<br>Signed-off-by: Lin Huang <hl@rock-chips.com><br>---<br>M src/mainboard/google/gru/board.h<br>M src/mainboard/google/gru/mainboard.c<br>2 files changed, 11 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/22529/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/gru/board.h b/src/mainboard/google/gru/board.h<br>index f95db57..3d769d7 100644<br>--- a/src/mainboard/google/gru/board.h<br>+++ b/src/mainboard/google/gru/board.h<br>@@ -25,7 +25,8 @@<br> #define GPIO_SDMMC_PWR GPIO(4, D, 5)<br> <br> #if IS_ENABLED(CONFIG_BOARD_GOOGLE_SCARLET)<br>-#define GPIO_BACKLIGHT GPIO(4, C, 5)<br>+#define GPIO_BL_EN GPIO(4, C, 5)<br>+#define GPIO_BACKLIGHT GPIO(4, C, 6)<br> #define GPIO_EC_IN_RW GPIO(0, A, 1)<br> #define GPIO_EC_IRQ GPIO(1, C, 2)<br> #define GPIO_P15V_EN dead_code_t(gpio_t, "PP1500 doesn't exist on Scarlet")<br>@@ -36,7 +37,8 @@<br> #define GPIO_TPM_IRQ GPIO(1, C, 1)<br> #define GPIO_WP GPIO(0, B, 5)<br> #else<br>-#define GPIO_BACKLIGHT GPIO(1, C, 1)<br>+#define GPIO_BL_EN GPIO(1, C, 1)<br>+#define GPIO_BACKLIGHT dead_code_t(gpio_t, "backlight controlled by ec")<br> #define GPIO_EC_IN_RW GPIO(3, B, 0)<br> #define GPIO_EC_IRQ GPIO(0, A, 1)<br> #define GPIO_P15V_EN GPIO(0, B, 2)<br>diff --git a/src/mainboard/google/gru/mainboard.c b/src/mainboard/google/gru/mainboard.c<br>index 3721ce8..9fdfbf5 100644<br>--- a/src/mainboard/google/gru/mainboard.c<br>+++ b/src/mainboard/google/gru/mainboard.c<br>@@ -363,7 +363,13 @@<br> <br> void mainboard_power_on_backlight(void)<br> {<br>- gpio_output(GPIO_BACKLIGHT, 1); /* BL_EN */<br>+ gpio_output(GPIO_BL_EN, 1); /* BL_EN */<br>+<br>+ /*<br>+ * set backlight gpio to output,<br>+ * it will be controlled in depthcharge<br>+ */<br>+ gpio_output(GPIO_BACKLIGHT, 0);<br> <br> if (IS_ENABLED(CONFIG_BOARD_GOOGLE_GRU))<br> prepare_backlight_i2c();<br></pre><p>To view, visit <a href="https://review.coreboot.org/22529">change 22529</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22529"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7c5abfd5bbbae015b899f3edc8892ea32bf82463 </div>
<div style="display:none"> Gerrit-Change-Number: 22529 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Lin Huang <hl@rock-chips.com> </div>