<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22445">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/eve: Remove ACPI control of touchscreen power<br><br>Change the touchscreen power control back to coreboot instead of<br>under the ACPI _ON/_OFF methods, and switch the TOUCHSCREEN_STOP_L<br>pin back to an output.<br><br>This reverts previous changes to touchscreen GPIOs that were made<br>to get back to a known good/working state. This platform is not<br>intending to use S0ix so the ACPI control is not needed.<br><br>BUG=b:63718744<br>TEST=manual testing on Eve devices.<br><br>Change-Id: I3fd64a435a053da1558ef736fe7baceee3c8f3a0<br>Signed-off-by: Duncan Laurie <dlaurie@chromium.org><br>Original-Change-Id: Ia1e2ae7ca2a8b668c60fbda2aa50373e580646b2<br>Original-Signed-off-by: Duncan Laurie <dlaurie@chromium.org><br>Original-Reviewed-on: https://chromium-review.googlesource.com/572692<br>Original-Reviewed-by: Duncan Laurie <dlaurie@google.com><br>Original-Commit-Queue: Duncan Laurie <dlaurie@google.com><br>Original-Tested-by: Duncan Laurie <dlaurie@google.com><br>---<br>M src/mainboard/google/eve/devicetree.cb<br>M src/mainboard/google/eve/gpio.h<br>M src/mainboard/google/eve/smihandler.c<br>3 files changed, 8 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/22445/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb<br>index 2890e52..f0c2b69 100644<br>--- a/src/mainboard/google/eve/devicetree.cb<br>+++ b/src/mainboard/google/eve/devicetree.cb<br>@@ -236,10 +236,6 @@<br> register "generic.desc" = ""WCOM Digitizer""<br> register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E7_IRQ)"<br> register "generic.speed" = "I2C_SPEED_FAST_PLUS"<br>- register "generic.has_power_resource" = "1"<br>- register "generic.disable_gpio_export_in_crs" = "1"<br>- register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C22)"<br>- register "generic.enable_delay_ms" = "250"<br> register "hid_desc_reg_offset" = "0x1"<br> device i2c 0a on end<br> end<br>diff --git a/src/mainboard/google/eve/gpio.h b/src/mainboard/google/eve/gpio.h<br>index b9b37a0..5deb809 100644<br>--- a/src/mainboard/google/eve/gpio.h<br>+++ b/src/mainboard/google/eve/gpio.h<br>@@ -121,10 +121,9 @@<br> /* I2C1_SCL */ PAD_CFG_NF(GPP_C19, NONE, DEEP, NF1), /* TPM */<br> /* UART2_RXD */ PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), /* SERVO */<br> /* UART2_TXD */ PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), /* SERVO */<br>-/* UART2_RTS# */ PAD_CFG_GPO(GPP_C22, 0, DEEP), /* EN_PP3300_DX_TOUCHSCREEN */<br>+/* UART2_RTS# */ PAD_CFG_GPO(GPP_C22, 1, DEEP), /* EN_PP3300_DX_TOUCHSCREEN */<br> /* UART2_CTS# */ PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, 20K_PU,<br> DEEP), /* PCH_WP */<br>-<br> /* SPI1_CS# */ PAD_CFG_GPO(GPP_D0, 0, DEEP), /* TOUCHPAD_BOOT */<br> /* SPI1_CLK */ PAD_CFG_GPI_GPIO_DRIVER(GPP_D1, NONE,<br> DEEP), /* TOUCHPAD_RESET */<br>@@ -162,8 +161,7 @@<br> /* SATALED# */ PAD_CFG_NC(GPP_E8),<br> /* USB2_OCO# */ PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), /* USB_C0_OC_ODL */<br> /* USB2_OC1# */ PAD_CFG_NF(GPP_E10, NONE, DEEP, NF1), /* USB_C1_OC_ODL */<br>-/* USB2_OC2# */ PAD_CFG_GPI_GPIO_DRIVER(GPP_E11, NONE,<br>- DEEP), /* TOUCHSCREEN_STOP_L */<br>+/* USB2_OC2# */ PAD_CFG_GPO(GPP_E11, 1, DEEP), /* TOUCHSCREEN_STOP_L */<br> /* USB2_OC3# */ PAD_CFG_NC(GPP_E12),<br> /* DDPB_HPD0 */ PAD_CFG_NF(GPP_E13, 20K_PD, DEEP, NF1), /* USB_C0_DP_HPD */<br> /* DDPC_HPD1 */ PAD_CFG_NF(GPP_E14, 20K_PD, DEEP, NF1), /* USB_C1_DP_HPD */<br>diff --git a/src/mainboard/google/eve/smihandler.c b/src/mainboard/google/eve/smihandler.c<br>index f51248c..e449900 100644<br>--- a/src/mainboard/google/eve/smihandler.c<br>+++ b/src/mainboard/google/eve/smihandler.c<br>@@ -30,6 +30,12 @@<br> {<br> /* Power down the rails on any sleep type */<br> gpio_set(EN_PP3300_DX_CAM, 0);<br>+<br>+ /* Assert TOUSHCREEN_STOP_L */<br>+ gpio_set(GPP_E11, 0);<br>+<br>+ /* Turn off touchscreen power */<br>+ gpio_set(GPP_C22, 0);<br> }<br> <br> void mainboard_smi_sleep(u8 slp_typ)<br></pre><p>To view, visit <a href="https://review.coreboot.org/22445">change 22445</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22445"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3fd64a435a053da1558ef736fe7baceee3c8f3a0 </div>
<div style="display:none"> Gerrit-Change-Number: 22445 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>