<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22440">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">amd/stoneyridge: Update def_callouts.c to reset using reset.c<br><br>Convert functionality to use coreboot-centric functions and defined<br>values. This change should have no functional effect.<br><br>BUG=b:62241048<br>TEST=Build Gardenia; Build & boot Kahlee.<br><br>Change-Id: I62ae50af05d3ac770560368245c4ae81cf9c4395<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/soc/amd/common/def_callouts.c<br>1 file changed, 6 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/22440/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/amd/common/def_callouts.c b/src/soc/amd/common/def_callouts.c<br>index e8d404e..4e42e9e 100644<br>--- a/src/soc/amd/common/def_callouts.c<br>+++ b/src/soc/amd/common/def_callouts.c<br>@@ -18,6 +18,7 @@<br> #include <amdlib.h><br> #include <BiosCallOuts.h><br> #include "agesawrapper.h"<br>+#include <reset.h><br> #include <soc/southbridge.h><br> <br> #if ENV_BOOTBLOCK<br>@@ -100,7 +101,6 @@<br> AGESA_STATUS agesa_Reset(UINT32 Func, UINTN Data, VOID *ConfigPtr)<br> {<br> AGESA_STATUS Status;<br>- UINT8 Value;<br> UINTN ResetType;<br> AMD_CONFIG_PARAMS *StdHeader;<br> <br>@@ -114,11 +114,13 @@<br> */<br> switch (ResetType) {<br> case WARM_RESET_WHENEVER:<br>- case COLD_RESET_WHENEVER:<br> case WARM_RESET_IMMEDIATELY:<br>+ do_soft_reset();<br>+ break;<br>+<br>+ case COLD_RESET_WHENEVER:<br> case COLD_RESET_IMMEDIATELY:<br>- Value = 0x06;<br>- LibAmdIoWrite(AccessWidth8, SYS_RESET, &Value, StdHeader);<br>+ do_hard_reset();<br> break;<br> <br> default:<br></pre><p>To view, visit <a href="https://review.coreboot.org/22440">change 22440</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22440"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I62ae50af05d3ac770560368245c4ae81cf9c4395 </div>
<div style="display:none"> Gerrit-Change-Number: 22440 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>