<p>Marshall Dawson has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22427">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">amd/stoneyridge: Replace BIT(n) in southbridge<br><br>Use more descriptive #define values for the ACPI features and<br>register decoding.<br><br>Change-Id: Iaaf9f9bd5761001bc4bfe6b64a6c72b1f04844bd<br>Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com><br>---<br>M src/soc/amd/stoneyridge/southbridge.c<br>1 file changed, 5 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/22427/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c<br>index 0d96b5f..6ab0678 100644<br>--- a/src/soc/amd/stoneyridge/southbridge.c<br>+++ b/src/soc/amd/stoneyridge/southbridge.c<br>@@ -61,10 +61,11 @@<br>                 pm_write16(PM_ACPI_SMI_CMD, 0);<br>       }<br> <br>- /* AcpiDecodeEnable, When set, SB uses the contents of the PM registers<br>-       * at index 60-6B to decode ACPI I/O address. AcpiSmiEn & SmiCmdEn<br>-        */<br>-  pm_write8(PM_ACPI_CONF, BIT(0) | BIT(1) | BIT(4) | BIT(2));<br>+  /* Decode ACPI registers and enable standard features */<br>+     pm_write8(PM_ACPI_CONF, PM_ACPI_DECODE_STD |<br>+                         PM_ACPI_GLOBAL_EN |<br>+                          PM_ACPI_RTC_EN_EN |<br>+                          PM_ACPI_TIMER_EN_EN);<br> }<br> <br> void southbridge_init(void *chip_info)<br></pre><p>To view, visit <a href="https://review.coreboot.org/22427">change 22427</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22427"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iaaf9f9bd5761001bc4bfe6b64a6c72b1f04844bd </div>
<div style="display:none"> Gerrit-Change-Number: 22427 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>