<p>Marshall Dawson has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22424">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">amd/stoneyridge: Fix DRAM clear check<br><br>Add appropriate #include files to romstage.c to ensure sizes of the<br>devicetree structures are correct.  This fixes a bug where dev->chip_info<br>is incorrectly detected as 0.<br><br>Also shorten a printk string to bring the source line within 80 columns.<br><br>Change-Id: I1ed51cdbb8df387a453de6cb944b90538dac4431<br>Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com><br>---<br>M src/soc/amd/stoneyridge/romstage.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/22424/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/amd/stoneyridge/romstage.c b/src/soc/amd/stoneyridge/romstage.c<br>index 9b22761..f54eafe 100644<br>--- a/src/soc/amd/stoneyridge/romstage.c<br>+++ b/src/soc/amd/stoneyridge/romstage.c<br>@@ -21,6 +21,8 @@<br> #include <cbmem.h><br> #include <commonlib/helpers.h><br> #include <console/console.h><br>+#include <device/device.h><br>+#include <chip.h><br> #include <program_loading.h><br> #include <agesawrapper.h><br> #include <agesawrapper_call.h><br>@@ -118,7 +120,7 @@<br>  const struct device *dev = dev_find_slot(0, GNB_DEVFN);<br> <br>    if (!dev || !dev->chip_info) {<br>-            printk(BIOS_ERR, "ERROR: Could not find SoC devicetree config\n");<br>+         printk(BIOS_ERR, "ERROR: Cannot find SoC devicetree config\n");<br>             return;<br>       }<br> <br></pre><p>To view, visit <a href="https://review.coreboot.org/22424">change 22424</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22424"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1ed51cdbb8df387a453de6cb944b90538dac4431 </div>
<div style="display:none"> Gerrit-Change-Number: 22424 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>