<p>Marshall Dawson has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22246">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">amd/stoneyridge: Remove duplicate LPC decode setup<br><br>Delete the LPC I/O decode configuration from fixme.c. This code is<br>superseded by early_setup.c.<br><br>Change-Id: I86ac5e997c98fea853659bc66b13128f0872f571<br>Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com><br>---<br>M src/soc/amd/stoneyridge/fixme.c<br>1 file changed, 0 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/22246/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/amd/stoneyridge/fixme.c b/src/soc/amd/stoneyridge/fixme.c<br>index d3f5f6c..60cc2d1 100644<br>--- a/src/soc/amd/stoneyridge/fixme.c<br>+++ b/src/soc/amd/stoneyridge/fixme.c<br>@@ -66,8 +66,6 @@<br> void amd_initmmio(void)<br> {<br> UINT64 MsrReg;<br>- UINT32 PciData;<br>- PCI_ADDR PciAddress;<br> AMD_CONFIG_PARAMS StdHeader;<br> <br> /*<br>@@ -78,11 +76,6 @@<br> (LibAmdBitScanReverse(CONFIG_MMCONF_BUS_NUMBER) << 2)<br> | 1;<br> LibAmdMsrWrite(0xc0010058, &MsrReg, &StdHeader);<br>-<br>- /* For serial port */<br>- PciData = 0xff03ffd5;<br>- PciAddress.AddressValue = MAKE_SBDFO(0, 0, PCU_DEV, LPC_FUNC, 0x44);<br>- LibAmdPciWrite(AccessWidth32, PciAddress, &PciData, &StdHeader);<br> <br> /* Set ROM cache onto WP to decrease post time */<br> MsrReg = (0x0100000000ull - CACHE_ROM_SIZE) | 5ull;<br></pre><p>To view, visit <a href="https://review.coreboot.org/22246">change 22246</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22246"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I86ac5e997c98fea853659bc66b13128f0872f571 </div>
<div style="display:none"> Gerrit-Change-Number: 22246 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>