<p>Marshall Dawson has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22247">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd: Pass number of buses to mmio_init<br><br>This patch lays the groundwork for a subsequent patch that will eliminate<br>the amdlib functions from fixme.c.<br><br>Put the CONFIG value on the stack for amd_initmmio().  Eventually<br>LibAmdBitScanReverse() will be replaced with fms() which doesn't work<br>well with absolute values.<br><br>Change-Id: If875f46cff4cd8e63271939e122b22688552c4b4<br>Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com><br>---<br>M src/soc/amd/common/agesawrapper.h<br>M src/soc/amd/stoneyridge/bootblock/bootblock.c<br>M src/soc/amd/stoneyridge/fixme.c<br>3 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/22247/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/amd/common/agesawrapper.h b/src/soc/amd/common/agesawrapper.h<br>index b42f531..a9e6209 100644<br>--- a/src/soc/amd/common/agesawrapper.h<br>+++ b/src/soc/amd/common/agesawrapper.h<br>@@ -51,7 +51,7 @@<br> <br> VOID OemCustomizeInitEarly(IN OUT AMD_EARLY_PARAMS *InitEarly);<br> VOID amd_initcpuio(void);<br>-VOID amd_initmmio(void);<br>+VOID amd_initmmio(size_t max_bus);<br> const void *agesawrapper_locate_module(const CHAR8 name[8]);<br> <br> void OemPostParams(AMD_POST_PARAMS *PostParams);<br>diff --git a/src/soc/amd/stoneyridge/bootblock/bootblock.c b/src/soc/amd/stoneyridge/bootblock/bootblock.c<br>index 1712b51..7545a59 100644<br>--- a/src/soc/amd/stoneyridge/bootblock/bootblock.c<br>+++ b/src/soc/amd/stoneyridge/bootblock/bootblock.c<br>@@ -39,7 +39,7 @@<br> <br> void bootblock_soc_early_init(void)<br> {<br>-  amd_initmmio();<br>+      amd_initmmio(CONFIG_MMCONF_BUS_NUMBER);<br> <br>    if (!boot_cpu())<br>              bootblock_soc_init(); /* APs will not return */<br>diff --git a/src/soc/amd/stoneyridge/fixme.c b/src/soc/amd/stoneyridge/fixme.c<br>index 60cc2d1..214e7bb 100644<br>--- a/src/soc/amd/stoneyridge/fixme.c<br>+++ b/src/soc/amd/stoneyridge/fixme.c<br>@@ -63,7 +63,7 @@<br>       LibAmdPciWrite(AccessWidth32, PciAddress, &PciData, &StdHeader);<br> }<br> <br>-void amd_initmmio(void)<br>+void amd_initmmio(size_t max_bus)<br> {<br>     UINT64                        MsrReg;<br>         AMD_CONFIG_PARAMS             StdHeader;<br>@@ -73,7 +73,7 @@<br>     configuration base Address MSR register.<br>    */<br>    MsrReg = CONFIG_MMCONF_BASE_ADDRESS |<br>-                        (LibAmdBitScanReverse(CONFIG_MMCONF_BUS_NUMBER) << 2)<br>+                  (LibAmdBitScanReverse(max_bus) << 2)<br>                    | 1;<br>  LibAmdMsrWrite(0xc0010058, &MsrReg, &StdHeader);<br> <br></pre><p>To view, visit <a href="https://review.coreboot.org/22247">change 22247</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22247"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If875f46cff4cd8e63271939e122b22688552c4b4 </div>
<div style="display:none"> Gerrit-Change-Number: 22247 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>