<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22260">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/sandybridge/raminit: Fix PDWN_mode on desktops<br><br>On desktop boards the PPD bit of MRS register MR0 is set and thus<br>DLL_Off mode shouldn't be used, as enforced by datasheet<br>2nd-gen-core-family-mobile-vol-2-datasheet chapter 2.14.1.<br><br>Change-Id: Ic42f2ff3e719636be67b00fa37155939cd2e17de<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>---<br>M src/northbridge/intel/sandybridge/raminit_common.c<br>1 file changed, 8 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/22260/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c<br>index 88357f6..4c7d372 100644<br>--- a/src/northbridge/intel/sandybridge/raminit_common.c<br>+++ b/src/northbridge/intel/sandybridge/raminit_common.c<br>@@ -3197,7 +3197,14 @@<br> <br>         write32(DEFAULT_MCHBAR + 0x400c, (read32(DEFAULT_MCHBAR + 0x400c) & 0xFFFFCFFF) | 0x1000);  // OK<br>         write32(DEFAULT_MCHBAR + 0x440c, (read32(DEFAULT_MCHBAR + 0x440c) & 0xFFFFCFFF) | 0x1000);  // OK<br>-        write32(DEFAULT_MCHBAR + 0x4cb0, 0x00000740);<br>+<br>+     if (ctrl->mobile)<br>+         /* APD - DLL Off, 64 DCLKs until idle, decision per rank */<br>+          write32(DEFAULT_MCHBAR + 0x4cb0, 0x00000740);<br>+        else<br>+         /* APD - PPD, 64 DCLKs until idle, decision per rank */<br>+              write32(DEFAULT_MCHBAR + 0x4cb0, 0x00000340);<br>+<br>      write32(DEFAULT_MCHBAR + 0x4380, 0x00000aaa);   // OK<br>         write32(DEFAULT_MCHBAR + 0x4780, 0x00000aaa);   // OK<br>         write32(DEFAULT_MCHBAR + 0x4f88, 0x5f7003ff);   // OK<br></pre><p>To view, visit <a href="https://review.coreboot.org/22260">change 22260</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22260"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic42f2ff3e719636be67b00fa37155939cd2e17de </div>
<div style="display:none"> Gerrit-Change-Number: 22260 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>