<p>Lijian Zhao has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22234">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/apollolake: Move to common dsp driver<br><br>Move dsp driver implementation to common dsp driver.<br><br>TEST=Boot up and check dsp driver loaded or not in OS.<br><br>Change-Id: Ia2be1c9f18e0e110600bd56a0b6cb8d40ca5e01f<br>Signed-off-by: Lijian Zhao <lijian.zhao@intel.com><br>---<br>M src/soc/intel/apollolake/Kconfig<br>M src/soc/intel/apollolake/Makefile.inc<br>D src/soc/intel/apollolake/dsp.c<br>3 files changed, 1 insertion(+), 38 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/22234/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig<br>index e8bfb07..cf2492c 100644<br>--- a/src/soc/intel/apollolake/Kconfig<br>+++ b/src/soc/intel/apollolake/Kconfig<br>@@ -65,6 +65,7 @@<br>        select SOC_INTEL_COMMON_BLOCK<br>         select SOC_INTEL_COMMON_BLOCK_ACPI<br>    select SOC_INTEL_COMMON_BLOCK_CPU<br>+    select SOC_INTEL_COMMON_BLOCK_DSP<br>     select SOC_INTEL_COMMON_BLOCK_FAST_SPI<br>        select SOC_INTEL_COMMON_BLOCK_GPIO<br>    select SOC_INTEL_COMMON_BLOCK_GPIO_MULTI_ACPI_DEVICES<br>diff --git a/src/soc/intel/apollolake/Makefile.inc b/src/soc/intel/apollolake/Makefile.inc<br>index 2848bed..de27000 100644<br>--- a/src/soc/intel/apollolake/Makefile.inc<br>+++ b/src/soc/intel/apollolake/Makefile.inc<br>@@ -48,7 +48,6 @@<br> ramstage-y += chip.c<br> ramstage-y += cse.c<br> ramstage-y += elog.c<br>-ramstage-y += dsp.c<br> ramstage-y += graphics.c<br> ramstage-y += heci.c<br> ramstage-y += i2c.c<br>diff --git a/src/soc/intel/apollolake/dsp.c b/src/soc/intel/apollolake/dsp.c<br>deleted file mode 100644<br>index 76547ee..0000000<br>--- a/src/soc/intel/apollolake/dsp.c<br>+++ /dev/null<br>@@ -1,37 +0,0 @@<br>-/*<br>- * This file is part of the coreboot project.<br>- *<br>- * Copyright 2016 Google Inc.<br>- *<br>- * This program is free software; you can redistribute it and/or modify<br>- * it under the terms of the GNU General Public License as published by<br>- * the Free Software Foundation; version 2 of the License.<br>- *<br>- * This program is distributed in the hope that it will be useful,<br>- * but WITHOUT ANY WARRANTY; without even the implied warranty of<br>- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the<br>- * GNU General Public License for more details.<br>- */<br>-<br>-#include <device/device.h><br>-#include <device/pci.h><br>-#include <device/pci_ids.h><br>-<br>-static struct device_operations dsp_dev_ops = {<br>-       .read_resources         = &pci_dev_read_resources,<br>-       .set_resources          = &pci_dev_set_resources,<br>-        .enable_resources       = &pci_dev_enable_resources,<br>-     .scan_bus               = &scan_static_bus,<br>-};<br>-<br>-static const unsigned short pci_device_ids[] = {<br>-   PCI_DEVICE_ID_INTEL_APL_AUDIO,<br>-       PCI_DEVICE_ID_INTEL_GLK_AUDIO,<br>-       0,<br>-};<br>-<br>-static const struct pci_driver apollolake_dsp __pci_driver = {<br>-  .ops    = &dsp_dev_ops,<br>-  .vendor = PCI_VENDOR_ID_INTEL,<br>-       .devices = pci_device_ids,<br>-};<br></pre><p>To view, visit <a href="https://review.coreboot.org/22234">change 22234</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22234"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia2be1c9f18e0e110600bd56a0b6cb8d40ca5e01f </div>
<div style="display:none"> Gerrit-Change-Number: 22234 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> </div>