<p>Roy Mingi Park has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22236">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">md/google/soraka: enable 8254 Static Clock Gating for XTAL shutdown<br><br>8254 Static Clock Gating should be enabled for XTAL OSC shutdown<br>which has a power impact.<br><br>BUG=None<br>BRANCH=None<br>TEST=Build for kabylake board with the clock_gate_8254 policy in<br>devicetree set to 1.<br>iotools mmio_read32 0xfdc43300 should return 0x1f<br><br>Change-Id: I87fb6fa86f10be6e3c888dd3590d0e77a2b886e8<br>Signed-off-by: Roy Mingi Park <roy.mingi.park@intel.com><br>---<br>M src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>M src/soc/intel/skylake/chip.c<br>2 files changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/22236/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>index 1c342a4..40f0f0f 100644<br>--- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>+++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>@@ -60,6 +60,7 @@<br>     register "PmConfigSlpSusMinAssert" = "1"       # 500ms<br>    register "PmConfigSlpAMinAssert" = "3"         # 2s<br>       register "PmTimerDisabled" = "1"<br>+ register "clock_gate_8254" = "1"               # CGE for 8254 PIT<br> <br>      register "pirqa_routing" = "PCH_IRQ11"<br>    register "pirqb_routing" = "PCH_IRQ10"<br>diff --git a/src/soc/intel/skylake/chip.c b/src/soc/intel/skylake/chip.c<br>index dfa813a..7247b4a 100644<br>--- a/src/soc/intel/skylake/chip.c<br>+++ b/src/soc/intel/skylake/chip.c<br>@@ -204,6 +204,10 @@<br>     params->SendVrMbxCmd = config->SendVrMbxCmd;<br> <br>         soc_irq_settings(params);<br>+<br>+    /* Enable CGE for 8254 PIT due to xtal requirement */<br>+     params->Early8254ClockGatingEnable = config->clock_gate_8254;<br>+<br> }<br> <br> void soc_display_silicon_init_params(const SILICON_INIT_UPD *original,<br>@@ -808,6 +812,9 @@<br>   fsp_display_upd_value("SendVrMbxCmd", 1,<br>            original->SendVrMbxCmd,<br>            params->SendVrMbxCmd);<br>+    fsp_display_upd_value("Early8254ClockGatingEnable", 1,<br>+             original->Early8254ClockGatingEnable,<br>+             params->Early8254ClockGatingEnable);<br> }<br> <br> static void pci_set_subsystem(device_t dev, unsigned int vendor,<br></pre><p>To view, visit <a href="https://review.coreboot.org/22236">change 22236</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22236"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I87fb6fa86f10be6e3c888dd3590d0e77a2b886e8 </div>
<div style="display:none"> Gerrit-Change-Number: 22236 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Roy Mingi Park <roy.mingi.park@intel.com> </div>