<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22177">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/apollolake: Fix broken GNVS offset for chromeos<br><br>Change 03a235(soc/intel/apollolake: Add GNVS variables and include SGX<br>ASL) added new GNVS variables but did not adjust the unused array size<br>and thus broke chromeos offset.<br><br>This change fixes the above issue by reducing the size of unused array.<br><br>BUG=b:68254376<br>TEST=Verified that chromeos offset is correct. crossystem is able to<br>read all variables.<br><br>Change-Id: I279bfc4c702e46b88c1c7a067a24326ff8fed368<br>Signed-off-by: Furquan Shaikh <furquan@chromium.org><br>---<br>M src/soc/intel/apollolake/include/soc/nvs.h<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/22177/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/apollolake/include/soc/nvs.h b/src/soc/intel/apollolake/include/soc/nvs.h<br>index dd0746b..2c9a4b5 100644<br>--- a/src/soc/intel/apollolake/include/soc/nvs.h<br>+++ b/src/soc/intel/apollolake/include/soc/nvs.h<br>@@ -47,7 +47,7 @@<br>    uint8_t         ecps; /* 0x2C - SGX Enabled status */<br>         uint64_t        emna; /* 0x2D - 0x34 EPC base address */<br>      uint64_t        elng; /* 0x35 - 0x3C EPC Length */<br>-   uint8_t         unused[212];<br>+ uint8_t         unused[195];<br> <br>       /* ChromeOS specific (0x100 - 0xfff) */<br>       chromeos_acpi_t chromeos;<br></pre><p>To view, visit <a href="https://review.coreboot.org/22177">change 22177</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22177"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I279bfc4c702e46b88c1c7a067a24326ff8fed368 </div>
<div style="display:none"> Gerrit-Change-Number: 22177 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>