<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22083">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: Use newly added pmc_read_pm1_control<br><br>BUG=b:67874513<br><br>Change-Id: I298065f30647ae9bba8f6a8481bd34eec64f1d8e<br>Signed-off-by: Furquan Shaikh <furquan@chromium.org><br>---<br>M src/soc/intel/skylake/smihandler.c<br>1 file changed, 2 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/22083/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/skylake/smihandler.c b/src/soc/intel/skylake/smihandler.c<br>index daf8e0e..20c4109 100644<br>--- a/src/soc/intel/skylake/smihandler.c<br>+++ b/src/soc/intel/skylake/smihandler.c<br>@@ -140,7 +140,7 @@<br>   pmc_disable_smi(SLP_SMI_EN);<br> <br>       /* Figure out SLP_TYP */<br>-     reg32 = inl(ACPI_BASE_ADDRESS + PM1_CNT);<br>+    reg32 = pmc_read_pm1_control();<br>       printk(BIOS_SPEW, "SMI#: SLP = 0x%08x\n", reg32);<br>   slp_typ = acpi_sleep_from_pm1(reg32);<br> <br>@@ -213,8 +213,7 @@<br>          * the line above. However, if we entered sleep state S1 and wake<br>      * up again, we will continue to execute code in this function.<br>        */<br>-  reg32 = inl(ACPI_BASE_ADDRESS + PM1_CNT);<br>-    if (reg32 & SCI_EN) {<br>+    if (pmc_read_pm1_control() & SCI_EN) {<br>            /* The OS is not an ACPI OS, so we set the state to S0 */<br>             pmc_disable_pm1_control(SLP_EN | SLP_TYP);<br>    }<br></pre><p>To view, visit <a href="https://review.coreboot.org/22083">change 22083</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22083"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I298065f30647ae9bba8f6a8481bd34eec64f1d8e </div>
<div style="display:none"> Gerrit-Change-Number: 22083 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>