<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22088">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: Prevent false logs in pch_xhci_port_wake_check<br><br>1. Ensure that port_status read is not all 1s to ensure that read from<br>mmio address returned valid data.<br>2. If device connect/disconnect shows that it was a wake source, there<br>is no need to check for usb activity.<br><br>BUG=b:67874513<br><br>Change-Id: Id8b4a1fec7bfe530fe435a0f52944b273cdd89ad<br>Signed-off-by: Furquan Shaikh <furquan@chromium.org><br>---<br>M src/soc/intel/skylake/elog.c<br>1 file changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/22088/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/skylake/elog.c b/src/soc/intel/skylake/elog.c<br>index 8240457..2be6b7b 100644<br>--- a/src/soc/intel/skylake/elog.c<br>+++ b/src/soc/intel/skylake/elog.c<br>@@ -101,6 +101,10 @@<br>          /* Read port status and control register for the port. */<br>             port_status = read32((void *)base);<br> <br>+               /* Ensure that the status is not all 1s. */<br>+          if (port_status == 0xffffffff)<br>+                       continue;<br>+<br>          /*<br>             * Check if CSC bit is set and port is capable of wake on<br>              * connect/disconnect to identify if the port caused wake<br>@@ -110,6 +114,7 @@<br>                    pch_xhci_wake_capable(port_status)) {<br>                     elog_add_event_wake(event, i + 1);<br>                    found = true;<br>+                        continue;<br>             }<br> <br>          /*<br></pre><p>To view, visit <a href="https://review.coreboot.org/22088">change 22088</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22088"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id8b4a1fec7bfe530fe435a0f52944b273cdd89ad </div>
<div style="display:none"> Gerrit-Change-Number: 22088 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>