<p>Kevin Chiu has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22037">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/snappy: Override USB2 strength by SKUID<br><br>14" BigDaddy needs to override USB2 TxiSet additionally to<br>enhance driving strength.<br>Otherwise EA test will be failed on USB2 eye pattern.<br><br>BUG=b:67820719<br>BRANCH=reef<br>TEST=emerge-snappy coreboot<br>Change-Id: I674c121a71866a5d44439eeb49e07f917d816de8<br>Signed-off-by: Kevin Chiu <Kevin.Chiu@quantatw.com><br>---<br>M src/mainboard/google/reef/mainboard.c<br>M src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h<br>M src/mainboard/google/reef/variants/snappy/mainboard.c<br>3 files changed, 49 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/22037/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c<br>index 3de383a..196d6d3 100644<br>--- a/src/mainboard/google/reef/mainboard.c<br>+++ b/src/mainboard/google/reef/mainboard.c<br>@@ -44,6 +44,8 @@<br>       mainboard_ec_init();<br> <br>       variant_board_ec_set_skuid();<br>+<br>+     variant_board_usb_set(variant_board_sku());<br> }<br> <br> /*<br>@@ -72,6 +74,11 @@<br>   return board_sku_num;<br> }<br> <br>+/* Set variabnt board USB strength by sku id */<br>+void __attribute__((weak)) variant_board_usb_set(int skuid)<br>+{<br>+}<br>+<br> /* Set variabnt board sku to ec by sku id */<br> void __attribute__((weak)) variant_board_ec_set_skuid(void)<br> {<br>diff --git a/src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h<br>index 18fbf54..3658019 100644<br>--- a/src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h<br>+++ b/src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h<br>@@ -40,6 +40,7 @@<br> uint8_t variant_board_sku(void);<br> /* Set variabnt board sku to ec by sku id */<br> void variant_board_ec_set_skuid(void);<br>+void variant_board_usb_set(int skuid);<br> <br> /* Return ChromeOS gpio table and fill in number of entries. */<br> const struct cros_gpio *variant_cros_gpios(size_t *num);<br>diff --git a/src/mainboard/google/reef/variants/snappy/mainboard.c b/src/mainboard/google/reef/variants/snappy/mainboard.c<br>index 2767df2..a6c0ab8 100644<br>--- a/src/mainboard/google/reef/variants/snappy/mainboard.c<br>+++ b/src/mainboard/google/reef/variants/snappy/mainboard.c<br>@@ -17,6 +17,26 @@<br> #include <baseboard/variants.h><br> #include <ec/google/chromeec/ec.h><br> #include <vendorcode/google/chromeos/cros_vpd.h><br>+#include <console/console.h><br>+#include <device/pci.h><br>+#include <soc/pci_devs.h><br>+#include <soc/usb.h><br>+#include <soc/intel/apollolake/chip.h><br>+<br>+/* SKU ID enumeration */<br>+enum snappy_sku {<br>+       SKU_UNKNOWN = -1,<br>+    SKU_RESERVED0,<br>+       SKU_RESERVED1,<br>+       SKU_BIGDADDY_KBDBKLIGHT,<br>+     SKU_RESERVED3,<br>+       SKU_RESERVED4,<br>+       SKU_BIGDADDY,<br>+        SKU_RESERVED6,<br>+       SKU_ALAN,<br>+    SKU_SNAPPY,<br>+  SKU_COUNT,<br>+};<br> <br> void variant_board_ec_set_skuid(void)<br> {<br>@@ -63,3 +83,24 @@<br> <br>         return board_sku_num;<br> }<br>+<br>+void variant_board_usb_set(int skuid)<br>+{<br>+     struct device *dev = NB_DEV_ROOT;<br>+    static struct soc_intel_apollolake_config *cfg;<br>+<br>+   if (!dev || !dev->chip_info) {<br>+            printk(BIOS_ERR, "BUG! Could not find SOC devicetree config\n");<br>+           return;<br>+      }<br>+<br>+ cfg = dev->chip_info;<br>+<br>+  if ((skuid == SKU_BIGDADDY_KBDBKLIGHT) || (skuid == SKU_BIGDADDY)) {<br>+         /* override USB2#1 left PARA per port setting */<br>+             cfg->usb2eye[1].Usb20PerPortPeTxiSet = 7;<br>+         cfg->usb2eye[1].Usb20PerPortTxiSet = 7;<br>+           cfg->usb2eye[1].Usb20IUsbTxEmphasisEn = 3;<br>+                cfg->usb2eye[1].Usb20PerPortTxPeHalf = 0;<br>+ }<br>+}<br></pre><p>To view, visit <a href="https://review.coreboot.org/22037">change 22037</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22037"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I674c121a71866a5d44439eeb49e07f917d816de8 </div>
<div style="display:none"> Gerrit-Change-Number: 22037 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Chiu <Kevin.Chiu@quantatw.com> </div>