<p>Youness Alaoui has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22041">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">purism/librem13v2: Change DRAM Rcomp/DQS values<br><br>The RComp values have been updated to match what is shown in the schematics.<br><br>Extracting the Memory configuration blob from the original BIOS (A blob<br>which contains the correct binary sequence matching the RComp values appears<br>in object with GUID 2D27C618-7DCD-41F5-BB10-21166BE7E143), I could find<br>and confirm the DQ and DQS mapping.<br><br>Small code cleaning in romstage.c with no effect.<br><br>Change-Id: I35c734269b365fd759e9bd56224a80a8a8df5a57<br>Signed-off-by: Youness Alaoui <youness.alaoui@puri.sm><br>---<br>M src/mainboard/purism/librem13v2/pei_data.c<br>M src/mainboard/purism/librem13v2/romstage.c<br>2 files changed, 6 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/22041/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/purism/librem13v2/pei_data.c b/src/mainboard/purism/librem13v2/pei_data.c<br>index 84f38d9..730b730 100644<br>--- a/src/mainboard/purism/librem13v2/pei_data.c<br>+++ b/src/mainboard/purism/librem13v2/pei_data.c<br>@@ -29,14 +29,14 @@<br>                    0x33, 0x00, 0xFF, 0x00, 0xFF, 0x00 } };<br>   /* DQS CPU<>DRAM map */<br>         const u8 dqs_map[2][8] = {<br>-           { 0, 3, 1, 2, 4, 5, 6, 7 },<br>+          { 0, 1, 3, 2, 4, 5, 6, 7 },<br>           { 1, 0, 4, 5, 2, 3, 6, 7 } };<br> <br>      /* Rcomp resistor */<br>- const u16 RcompResistor[3] = { 200, 81, 162 };<br>+       const u16 RcompResistor[3] = { 121, 81, 100 };<br> <br>     /* Rcomp target */<br>-   const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };<br>+  const u16 RcompTarget[5] = { 100, 40, 20, 20, 26 };<br> <br>        memcpy(pei_data->dq_map, dq_map, sizeof(dq_map));<br>  memcpy(pei_data->dqs_map, dqs_map, sizeof(dqs_map));<br>diff --git a/src/mainboard/purism/librem13v2/romstage.c b/src/mainboard/purism/librem13v2/romstage.c<br>index c8c3cd9..fc940e1 100644<br>--- a/src/mainboard/purism/librem13v2/romstage.c<br>+++ b/src/mainboard/purism/librem13v2/romstage.c<br>@@ -38,11 +38,11 @@<br>                 .addr_map = { 0x50 },<br>         };<br> <br>-        memory_params->DqPinsInterleaved = 1;<br>      get_spd_smbus(&blk);<br>      dump_spd_info(&blk);<br>-     memory_params->MemorySpdDataLen = blk.len;<br>         assert(blk.spd_array[0][0] != 0);<br>+<br>+ memory_params->MemorySpdDataLen = blk.len;<br>         memory_params->MemorySpdPtr00 = (uintptr_t) blk.spd_array[0];<br>      memory_params->MemorySpdPtr01 = 0;<br>         memory_params->MemorySpdPtr10 = 0;<br>@@ -60,5 +60,6 @@<br>              sizeof(params->pei_data->RcompResistor));<br>       memcpy(memory_params->RcompTarget, params->pei_data->RcompTarget,<br>            sizeof(params->pei_data->RcompTarget));<br>+        memory_params->DqPinsInterleaved = TRUE;<br> <br> }<br></pre><p>To view, visit <a href="https://review.coreboot.org/22041">change 22041</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22041"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I35c734269b365fd759e9bd56224a80a8a8df5a57 </div>
<div style="display:none"> Gerrit-Change-Number: 22041 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Youness Alaoui <snifikino@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com> </div>