<p>Youness Alaoui has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21958">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">intel/skylake: Use Sata related registers from devicetree<br><br>Enable the use of the SataPortsEnable and SataPortsDevSlp registers<br>which were being ignored from the devicetree and were not affecting<br>the resulting UPD parameters.<br><br>SataPortsEnable was only being copied for the first SATA port, while<br>the other ports were left ignored.<br><br>Change-Id: Iae70a4d6375fa5d1b05ee89f6b97c65dbbf28dda<br>Signed-off-by: Youness Alaoui <youness.alaoui@puri.sm><br>---<br>M src/soc/intel/skylake/chip.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/21958/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/skylake/chip.c b/src/soc/intel/skylake/chip.c<br>index 7014c24..dfa813a 100644<br>--- a/src/soc/intel/skylake/chip.c<br>+++ b/src/soc/intel/skylake/chip.c<br>@@ -132,7 +132,10 @@<br>        params->EnableLan = config->EnableLan;<br>  params->Cio2Enable = config->Cio2Enable;<br>        params->SataSalpSupport = config->SataSalpSupport;<br>-     params->SataPortsEnable[0] = config->SataPortsEnable[0];<br>+       memcpy(params->SataPortsEnable, config->SataPortsEnable,<br>+                       sizeof(params->SataPortsEnable));<br>+ memcpy(params->SataPortsDevSlp, config->SataPortsDevSlp,<br>+                       sizeof(params->SataPortsDevSlp));<br>  params->SsicPortEnable = config->SsicPortEnable;<br>        params->SmbusEnable = config->SmbusEnable;<br>      params->ScsEmmcEnabled = config->ScsEmmcEnabled;<br></pre><p>To view, visit <a href="https://review.coreboot.org/21958">change 21958</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21958"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iae70a4d6375fa5d1b05ee89f6b97c65dbbf28dda </div>
<div style="display:none"> Gerrit-Change-Number: 21958 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Youness Alaoui <snifikino@gmail.com> </div>