<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21910">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/soraka: Add 10ms reset delay for WCOM device<br><br>Change 868b3761 (mainboard/google/soraka: Reduce Wacom resume time)<br>removed the delay after taking device out of reset since it seemed<br>unnecessary in system resume case (because there is enough time after<br>taking device out of reset and before communication with device<br>starts).<br><br>However, without the delay, kernel driver runs into issue while<br>talking to the device during boot-up and runtime<br>suspend/resume. (Observed this error in dmesg: "i2c_hid<br>i2c-WCOMCOHO:00: failed to change power setting."). Thus, add 10ms<br>delay after taking device out of reset. Verified on multiple Soraka<br>system that with 10ms delay, kernel driver does not run into any issue<br>talking to the WCOM device during boot-up, runtime suspend/resume and<br>system suspend/resume.<br><br>BUG=b:65358919<br>TEST=No more errors talking to WCOM device in kernel dmesg.<br><br>Change-Id: I485b753cbae4b653e74337e048aea4d26ffdbb81<br>---<br>M src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/21910/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>index f6948d9..1c342a4 100644<br>--- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>+++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>@@ -281,6 +281,7 @@<br>                          register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E7_IRQ)"<br>                                 register "generic.probed" = "1"<br>                           register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E3)"<br>+                            register "generic.reset_delay_ms" = "10"<br>                          register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C22)"<br>                          register "generic.enable_delay_ms" = "1"<br>                          register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E11)"<br></pre><p>To view, visit <a href="https://review.coreboot.org/21910">change 21910</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21910"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I485b753cbae4b653e74337e048aea4d26ffdbb81 </div>
<div style="display:none"> Gerrit-Change-Number: 21910 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>