<p>Shaunak Saha has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21909">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/soc/skylake: Fix Null pointer dereferences<br><br>Fix bug detected by coverity to handle the NULL pointer dereference<br><br>Coverity Issues:<br>* 1379849<br>* 1379848<br><br>TEST=Build and run on skylake platform<br><br>Change-Id: Iec7a88a03531bbfeb72cedab5ad93d3a4c23eef5<br>Signed-off-by: Shaunak Saha <shaunak.saha@intel.com><br>---<br>M src/soc/intel/skylake/pmutil.c<br>1 file changed, 8 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/21909/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/skylake/pmutil.c b/src/soc/intel/skylake/pmutil.c<br>index 9dd22e9..d7ed100 100644<br>--- a/src/soc/intel/skylake/pmutil.c<br>+++ b/src/soc/intel/skylake/pmutil.c<br>@@ -210,19 +210,22 @@<br> <br> void soc_get_gpe_configs(uint8_t *dw0, uint8_t *dw1, uint8_t *dw2)<br> {<br>-  DEVTREE_CONST struct soc_intel_skylake_config *config;<br>+       DEVTREE_CONST struct soc_intel_skylake_config *config = NULL;<br> <br>      /* Look up the device in devicetree */<br>        DEVTREE_CONST struct device *dev = dev_find_slot(0, PCH_DEVFN_PMC);<br>   if (!dev || !dev->chip_info) {<br>             printk(BIOS_ERR, "BUG! Could not find SOC devicetree config\n");<br>+           return;<br>       }<br>     config = dev->chip_info;<br> <br>-       /* Assign to out variable */<br>- *dw0 = config->gpe0_dw0;<br>-  *dw1 = config->gpe0_dw1;<br>-  *dw2 = config->gpe0_dw2;<br>+  if(config != NULL) {<br>+         /* Assign to out variable */<br>+         *dw0 = config->gpe0_dw0;<br>+          *dw1 = config->gpe0_dw1;<br>+          *dw2 = config->gpe0_dw2;<br>+  }<br> }<br> <br> int rtc_failure(void)<br></pre><p>To view, visit <a href="https://review.coreboot.org/21909">change 21909</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21909"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iec7a88a03531bbfeb72cedab5ad93d3a4c23eef5 </div>
<div style="display:none"> Gerrit-Change-Number: 21909 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Shaunak Saha <shaunak.saha@intel.com> </div>