<p>Rizwan Qureshi has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21875">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/{common,apollolake}: fix coverity issues<br><br>fix issues reported by coverity scan in the below files<br><br>src/soc/intel/common/block/i2c<br>  1375440: Improper use of negative value<br>       1375441: Improper use of negative value<br>       1375444: Improper use of negative value<br><br>src/soc/intel/apollolake/i2c.c<br>     1375442: Unsigned compared against 0<br><br>Change-Id: Ic65400c934631e3dcd3aa664c24cb451616e7f4d<br>Signed-off-by: Rizwan Qureshi <rizwan.qureshi@intel.com><br>---<br>M src/soc/intel/apollolake/i2c.c<br>M src/soc/intel/common/block/i2c/i2c.c<br>2 files changed, 8 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/21875/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/apollolake/i2c.c b/src/soc/intel/apollolake/i2c.c<br>index 2b6cbf9..4ae500e 100644<br>--- a/src/soc/intel/apollolake/i2c.c<br>+++ b/src/soc/intel/apollolake/i2c.c<br>@@ -44,7 +44,7 @@<br> /* Convert I2C bus number to PCI device and function */<br> int i2c_soc_bus_to_devfn(unsigned int bus)<br> {<br>-  if (bus >= 0 && bus <= 3)<br>+      if (bus <= 3)<br>              return PCI_DEVFN(PCH_DEV_SLOT_SIO1, bus);<br>     else if (bus >= 4 && bus <= 7)<br>          return PCI_DEVFN(PCH_DEV_SLOT_SIO2, (bus - 4));<br>diff --git a/src/soc/intel/common/block/i2c/i2c.c b/src/soc/intel/common/block/i2c/i2c.c<br>index 625bb99..c6f3be2 100644<br>--- a/src/soc/intel/common/block/i2c/i2c.c<br>+++ b/src/soc/intel/common/block/i2c/i2c.c<br>@@ -96,9 +96,12 @@<br>  const struct lpss_i2c_bus_config *config;<br>     int bus = lpss_i2c_dev_to_bus(dev);<br> <br>+       if (bus < 0)<br>+              return;<br>+<br>    config = i2c_get_soc_cfg(bus, dev);<br> <br>-       if (!config || bus < 0)<br>+   if (!config)<br>          return;<br> <br>    lpss_i2c_init(bus, config);<br>@@ -126,6 +129,9 @@<br> <br>   bus = lpss_i2c_dev_to_bus(dev);<br> <br>+   if (bus < 0)<br>+              return;<br>+<br>    bcfg = i2c_get_soc_cfg(bus, dev);<br> <br>  if (!bcfg)<br></pre><p>To view, visit <a href="https://review.coreboot.org/21875">change 21875</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21875"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic65400c934631e3dcd3aa664c24cb451616e7f4d </div>
<div style="display:none"> Gerrit-Change-Number: 21875 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>