<p>Marshall Dawson has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21853">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/kahlee: Add defines in OemCustomize.c<br><br>Add a #define for MB_DIMM_SLOTS and verify it doesn't exceed the max<br>supported for the device. AGESA's DRAM procedures follow the BKDG and<br>may vary depending on the number of slots on the motherboard. DIMM<br>numbering and ordering is also affected by this value.<br><br>Replace hardcoded integers with defined values for DIMM slots and<br>number of channels.<br><br>Change-Id: I4f7336da80b4e3d7f351502a63de0652e9ff5395<br>Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com><br>---<br>M src/mainboard/google/kahlee/OemCustomize.c<br>1 file changed, 8 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/21853/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/kahlee/OemCustomize.c b/src/mainboard/google/kahlee/OemCustomize.c<br>index 528c7b3..878e2b9 100644<br>--- a/src/mainboard/google/kahlee/OemCustomize.c<br>+++ b/src/mainboard/google/kahlee/OemCustomize.c<br>@@ -1,7 +1,7 @@<br> /*<br> * This file is part of the coreboot project.<br> *<br>- * Copyright (C) 2015-2016 Advanced Micro Devices, Inc.<br>+ * Copyright (C) 2015-2017 Advanced Micro Devices, Inc.<br> *<br> * This program is free software; you can redistribute it and/or modify<br> * it under the terms of the GNU General Public License as published by<br>@@ -13,16 +13,20 @@<br> * GNU General Public License for more details.<br> */<br> <br>+#include <chip.h><br> #include <AGESA.h><br> #include <agesawrapper.h><br> #include <PlatformMemoryConfiguration.h><br> <br>-#define FILECODE PROC_GNB_PCIE_FAMILY_0X15_F15PCIECOMPLEXCONFIG_FILECODE<br>+#define MB_DIMM_SLOTS 1<br>+#if MB_DIMM_SLOTS > MAX_DIMMS_PER_CH<br>+#error "Too many DIMM sockets defined for the mainboard"<br>+#endif<br> <br> static const PSO_ENTRY DDR4PlatformMemoryConfiguration[] = {<br> DRAM_TECHNOLOGY(ANY_SOCKET, DDR4_TECHNOLOGY),<br>- NUMBER_OF_DIMMS_SUPPORTED(ANY_SOCKET, ANY_CHANNEL, 1),<br>- NUMBER_OF_CHANNELS_SUPPORTED(ANY_SOCKET, 1),<br>+ NUMBER_OF_DIMMS_SUPPORTED(ANY_SOCKET, ANY_CHANNEL, MB_DIMM_SLOTS),<br>+ NUMBER_OF_CHANNELS_SUPPORTED(ANY_SOCKET, MAX_DRAM_CH),<br> MOTHER_BOARD_LAYERS(LAYERS_6),<br> MEMCLK_DIS_MAP(ANY_SOCKET, ANY_CHANNEL,<br> 0xff, 0xff, 0xff, 0xff, 0x00, 0x00, 0x00, 0x00),<br></pre><p>To view, visit <a href="https://review.coreboot.org/21853">change 21853</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21853"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4f7336da80b4e3d7f351502a63de0652e9ff5395 </div>
<div style="display:none"> Gerrit-Change-Number: 21853 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>