<p>Vagiz Tarkhanov has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21841">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/sandybridge: Add a kconfig option to ignore XMP max DIMMs<br><br>XMP profiles can have a restriction on max supported DIMMs per channel,<br>but many configurations work with more DIMMs.<br><br>This is relevant on mainboards with 2 DIMM slots per channel (usually 4<br>in total). Populating both slots with DIMMs that support XMP profiles only<br>with 1 DIMM per channel turns off said XMP profiles.<br><br>Change-Id: I1f22d981afcef0ee73785823b0a943cf3d3564e3<br>Signed-off-by: Vagiz Trakhanov <rakkin@autistici.org><br>---<br>M src/northbridge/intel/sandybridge/Kconfig<br>M src/northbridge/intel/sandybridge/raminit.c<br>2 files changed, 11 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/21841/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/northbridge/intel/sandybridge/Kconfig b/src/northbridge/intel/sandybridge/Kconfig<br>index 1a47f0d..5ffb796 100644<br>--- a/src/northbridge/intel/sandybridge/Kconfig<br>+++ b/src/northbridge/intel/sandybridge/Kconfig<br>@@ -54,6 +54,15 @@<br>       Disabled by default as it might causes system instability.<br>    Handle with care!<br> <br>+config NATIVE_RAMINIT_IGNORE_XMP_MAX_DIMMS<br>+  bool "Ignore XMP profile max DIMMs per channel"<br>+    default n<br>+    depends on USE_NATIVE_RAMINIT<br>+        help<br>+   Ignore the max DIMMs per channel restriciton defined in XMP profiles.<br>+        Disabled by default as it might causes system instability.<br>+   Handle with care!<br>+<br> config CBFS_SIZE<br>     hex<br>   default 0x100000<br>diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c<br>index bdba748..6e4d63f 100644<br>--- a/src/northbridge/intel/sandybridge/raminit.c<br>+++ b/src/northbridge/intel/sandybridge/raminit.c<br>@@ -230,7 +230,8 @@<br>                    if (dimm->dimm[channel][slot].dram_type != SPD_MEMORY_TYPE_SDRAM_DDR3) {<br>                           printram("No valid XMP profile found.\n");<br>                          spd_decode_ddr3(&dimm->dimm[channel][slot], spd[spd_slot]);<br>-                   } else if (dimms_on_channel > dimm->dimm[channel][slot].dimms_per_channel) {<br>+                   } else if ((dimms_on_channel > dimm->dimm[channel][slot].dimms_per_channel)<br>+                               && !IS_ENABLED(CONFIG_NATIVE_RAMINIT_IGNORE_XMP_MAX_DIMMS)) {<br>                              printram("XMP profile supports %u DIMMs, but %u DIMMs are installed.\n",<br>                                             dimm->dimm[channel][slot].dimms_per_channel,<br>                                               dimms_on_channel);<br></pre><p>To view, visit <a href="https://review.coreboot.org/21841">change 21841</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21841"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1f22d981afcef0ee73785823b0a943cf3d3564e3 </div>
<div style="display:none"> Gerrit-Change-Number: 21841 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vagiz Tarkhanov <rakkin@autistici.org> </div>