<p>Arthur Heymans <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/21841">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/21841/1/src/northbridge/intel/sandybridge/raminit.c">File src/northbridge/intel/sandybridge/raminit.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21841/1/src/northbridge/intel/sandybridge/raminit.c@238">Patch Set #1, Line 238:</a> <code style="font-family:monospace,monospace">spd_decode_ddr3(&dimm->dimm[channel][slot], spd[spd_slot]);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">maybe only apply Kconfig condition on this line? It's still useful to know from the debug message if your setup is in principle not supported.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/21841">change 21841</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21841"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I1f22d981afcef0ee73785823b0a943cf3d3564e3 </div>
<div style="display:none"> Gerrit-Change-Number: 21841 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vagiz Tarkhanov <rakkin@autistici.org> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 02 Oct 2017 13:57:55 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>