<p>Rizwan Qureshi has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21730">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">acpi: [TESTONLY] add debug print to SSDT<br><br>Change-Id: I8e85c41999bd8c93bcc67b17a914cba6ac57ad9e<br>Signed-off-by: Rizwan Qureshi <rizwan.qureshi@intel.corp-partner.google.com><br>---<br>M src/arch/x86/acpi_device.c<br>M src/arch/x86/include/arch/acpi_device.h<br>M src/drivers/i2c/generic/chip.h<br>M src/drivers/i2c/generic/generic.c<br>M src/drivers/spi/acpi/acpi.c<br>M src/drivers/spi/acpi/chip.h<br>M src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>7 files changed, 13 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/21730/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/arch/x86/acpi_device.c b/src/arch/x86/acpi_device.c<br>index 31e59ea..afd95ab 100644<br>--- a/src/arch/x86/acpi_device.c<br>+++ b/src/arch/x86/acpi_device.c<br>@@ -470,6 +470,7 @@<br> <br> /* PowerResource() with Enable and/or Reset control */<br> void acpi_device_add_power_res(<br>+ u8 debug,<br> struct acpi_gpio *reset, unsigned int reset_delay_ms,<br> struct acpi_gpio *enable, unsigned int enable_delay_ms,<br> struct acpi_gpio *stop, unsigned int stop_delay_ms)<br>@@ -491,6 +492,8 @@<br> <br> /* Method (_ON, 0, Serialized) */<br> acpigen_write_method_serialized("_ON", 0);<br>+ if (debug)<br>+ acpigen_write_debug_string("ACPI _ON method entry");<br> if (reset_gpio)<br> acpigen_enable_tx_gpio(reset);<br> if (enable_gpio) {<br>@@ -512,6 +515,8 @@<br> <br> /* Method (_OFF, 0, Serialized) */<br> acpigen_write_method_serialized("_OFF", 0);<br>+ if (debug)<br>+ acpigen_write_debug_string("ACPI _OFF method entry");<br> if (stop_gpio)<br> acpigen_enable_tx_gpio(stop);<br> if (reset_gpio)<br>diff --git a/src/arch/x86/include/arch/acpi_device.h b/src/arch/x86/include/arch/acpi_device.h<br>index d4d82fc..279a362 100644<br>--- a/src/arch/x86/include/arch/acpi_device.h<br>+++ b/src/arch/x86/include/arch/acpi_device.h<br>@@ -316,6 +316,7 @@<br> * Stop - Stop / start operation of device.<br> */<br> void acpi_device_add_power_res(<br>+ u8 debug,<br> struct acpi_gpio *reset, unsigned int reset_delay_ms,<br> struct acpi_gpio *enable, unsigned int enable_delay_ms,<br> struct acpi_gpio *stop, unsigned int stop_delay_ms);<br>diff --git a/src/drivers/i2c/generic/chip.h b/src/drivers/i2c/generic/chip.h<br>index 037a800..acba22e 100644<br>--- a/src/drivers/i2c/generic/chip.h<br>+++ b/src/drivers/i2c/generic/chip.h<br>@@ -66,6 +66,8 @@<br> /* Delay to be inserted after disabling stop. */<br> unsigned stop_delay_ms;<br> <br>+ u8 power_res_debug;<br>+<br> /* Generic properties for exporting device-specific data to the OS */<br> struct acpi_dp property_list[MAX_GENERIC_PROPERTY_LIST];<br> int property_count;<br>diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c<br>index 13f8393..9ed74c4 100644<br>--- a/src/drivers/i2c/generic/generic.c<br>+++ b/src/drivers/i2c/generic/generic.c<br>@@ -144,6 +144,7 @@<br> /* Power Resource */<br> if (config->has_power_resource)<br> acpi_device_add_power_res(<br>+ config->power_res_debug,<br> &config->reset_gpio, config->reset_delay_ms,<br> &config->enable_gpio, config->enable_delay_ms,<br> &config->stop_gpio, config->stop_delay_ms);<br>diff --git a/src/drivers/spi/acpi/acpi.c b/src/drivers/spi/acpi/acpi.c<br>index d36a03a..fd21ca1 100644<br>--- a/src/drivers/spi/acpi/acpi.c<br>+++ b/src/drivers/spi/acpi/acpi.c<br>@@ -167,6 +167,7 @@<br> /* Power Resource */<br> if (config->has_power_resource)<br> acpi_device_add_power_res(<br>+ config->power_res_debug,<br> &config->reset_gpio, config->reset_delay_ms,<br> &config->enable_gpio, config->enable_delay_ms,<br> &config->stop_gpio, config->stop_delay_ms);<br>diff --git a/src/drivers/spi/acpi/chip.h b/src/drivers/spi/acpi/chip.h<br>index 35341d3..a334ca9 100644<br>--- a/src/drivers/spi/acpi/chip.h<br>+++ b/src/drivers/spi/acpi/chip.h<br>@@ -48,6 +48,8 @@<br> /* Delay to be inserted after device is enabled. */<br> unsigned enable_delay_ms;<br> <br>+ u8 power_res_debug;<br>+<br> /* GPIO used to stop operation of device. */<br> struct acpi_gpio stop_gpio;<br> /* Delay to be inserted after disabling stop. */<br>diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>index 6d4e8a5..d011924 100644<br>--- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>+++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>@@ -288,6 +288,7 @@<br> register "generic.has_power_resource" = "1"<br> register "generic.disable_gpio_export_in_crs" = "1"<br> register "hid_desc_reg_offset" = "0x1"<br>+ register "generic.power_res_debug" = "1"<br> device i2c 0xA on end<br> end<br> end # I2C #0<br></pre><p>To view, visit <a href="https://review.coreboot.org/21730">change 21730</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21730"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8e85c41999bd8c93bcc67b17a914cba6ac57ad9e </div>
<div style="display:none"> Gerrit-Change-Number: 21730 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>