<p>Marshall Dawson has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21752">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">WIP amd/stoneridge: Enable SMI trap on SlpTyp<br><br>Consider adding a check for HAVE_ACPI_RESUME, maybe SOC_AMD_COMMON_BLOCK_PSP.<br><br>Change-Id: I8db0df36b285ad26c8c9e62c3857fb6580c35229<br>Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com><br>---<br>M src/soc/amd/stoneyridge/southbridge.c<br>1 file changed, 9 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/21752/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c<br>index b5357a9..4c91efa 100644<br>--- a/src/soc/amd/stoneyridge/southbridge.c<br>+++ b/src/soc/amd/stoneyridge/southbridge.c<br>@@ -89,8 +89,17 @@<br>       pm_write16(PM_CPU_CTRL, ACPI_CPU_CONTROL);<br> <br>         if (IS_ENABLED(CONFIG_HAVE_SMI_HANDLER)) {<br>+           /* APMC - SMI Command Port */<br>                 pm_write16(PM_ACPI_SMI_CMD, APM_CNT);<br>                 configure_smi(SMITYPE_SMI_CMD_PORT, SMI_MODE_SMI);<br>+<br>+                /* SlpTypEn */<br>+               pm_write32(PM_PCI_CTRL,<br>+                              (pm_read32(PM_PCI_CTRL) | FORCE_SLPSTATE_RETRY)<br>+                              & ~FORCE_STPCLK_RETRY);<br>+          pm_write32(PM_RST_CTRL1,<br>+                             pm_read32(PM_RST_CTRL1) & ~SLPTYPE_CONTROL_EN);<br>+          configure_smi(SMITYPE_SLP_TYP, SMI_MODE_SMI);<br>         } else {<br>              pm_write16(PM_ACPI_SMI_CMD, 0);<br>       }<br></pre><p>To view, visit <a href="https://review.coreboot.org/21752">change 21752</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21752"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8db0df36b285ad26c8c9e62c3857fb6580c35229 </div>
<div style="display:none"> Gerrit-Change-Number: 21752 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>