<p>Vagiz Tarkhanov has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21754">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sandybridge/acpi: remove unnessary check of PCI IDs<br><br>DRAM Controller is always 00.0 No need to check its PCI ID.<br><br>Change-Id: I9c5f3e5658905e464491579f8da01aa6a03bd3b7<br>Signed-off-by: Vagiz Tarkhanov <rakkin@autistici.org><br>---<br>M src/northbridge/intel/sandybridge/acpi.c<br>M src/northbridge/intel/sandybridge/sandybridge.h<br>2 files changed, 1 insertion(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/21754/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/northbridge/intel/sandybridge/acpi.c b/src/northbridge/intel/sandybridge/acpi.c<br>index 658000aa..78225d0 100644<br>--- a/src/northbridge/intel/sandybridge/acpi.c<br>+++ b/src/northbridge/intel/sandybridge/acpi.c<br>@@ -26,14 +26,11 @@<br> <br> unsigned long acpi_fill_mcfg(unsigned long current)<br> {<br>-        device_t dev;<br>         u32 pciexbar = 0;<br>     u32 pciexbar_reg;<br>     int max_buses;<br> <br>-    dev = dev_find_device(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_SB, 0);<br>-     if (!dev)<br>-            dev = dev_find_device(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_IB, 0);<br>+     struct device *const dev = dev_find_slot(0, PCI_DEVFN(0, 0));<br>         if (!dev)<br>             return current;<br> <br>diff --git a/src/northbridge/intel/sandybridge/sandybridge.h b/src/northbridge/intel/sandybridge/sandybridge.h<br>index 9d88c70..dd1a58c 100644<br>--- a/src/northbridge/intel/sandybridge/sandybridge.h<br>+++ b/src/northbridge/intel/sandybridge/sandybridge.h<br>@@ -201,9 +201,6 @@<br> #ifndef __ASSEMBLER__<br> static inline void barrier(void) { asm("" ::: "memory"); }<br> <br>-#define PCI_DEVICE_ID_SB 0x0104<br>-#define PCI_DEVICE_ID_IB 0x0154<br>-<br> #ifdef __SMM__<br> void intel_sandybridge_finalize_smm(void);<br> #else /* !__SMM__ */<br></pre><p>To view, visit <a href="https://review.coreboot.org/21754">change 21754</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21754"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I9c5f3e5658905e464491579f8da01aa6a03bd3b7 </div>
<div style="display:none"> Gerrit-Change-Number: 21754 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vagiz Tarkhanov <rakkin@autistici.org> </div>